search

ices-tools-dev / RDBEScore

Provides functions to work with the Regional Database & Estimation System (RDBES)
https://ices-tools-dev.github.io/RDBEScore/
GNU General Public License v3.0
0 stars 4 forks source link

generateZerosUsingSL() is creating unnecessary extra rows #125

Closed davidcurrie2001 closed 1 year ago

davidcurrie2001 commented 1 year ago

@nmprista The tests in test-generateZerosUsingSL.R are failing because generateZerosUsingSL() is adding an unnecessary extra SA row for LAN even though a relevant LAN row already exists in the SA data.

nmprista commented 1 year ago

this should be fixed (tests now pass) but still a warning @davidcurrie2001

KirstenBirchHaakansson commented 1 year ago

it still add too many lines, see attachement testing_generateZerosUsingSL.pdf

KirstenBirchHaakansson commented 1 year ago

See scripts at ...\RDBEScore\WGRDBES-EST\personal\Kirsten\testing_generateZerosUsingSL.rmd