search

ices-tools-dev / RDBEScore

Provides functions to work with the Regional Database & Estimation System (RDBES)
https://ices-tools-dev.github.io/RDBEScore/
GNU General Public License v3.0
0 stars 4 forks source link

generateMissingSSRows() will probably fail for data that doesn't pass "strict" validation #179

Closed davidcurrie2001 closed 1 year ago

davidcurrie2001 commented 1 year ago

generateMissingSSRows() assumes that the SS rows it creates should have all the columns in the SS table. This might cause a problem if your SS data only passes the strict = FALSE validation - in that case your data might not have all the columns, or it might have extra columns. The function should look at which columns are actually in your SS data to decide which columns are added to the missing SS rows it creates.

davidcurrie2001 commented 1 year ago

Should be fixed now - tests added to check behaviour with non-strict validating data.