search

ices-tools-dev / RDBEScore

Provides functions to work with the Regional Database & Estimation System (RDBES)
https://ices-tools-dev.github.io/RDBEScore/
GNU General Public License v3.0
0 stars 4 forks source link

removeBrokenSpeciesListLinks has a dependency on dplyr version - this is now added to Description #188

Closed davidcurrie2001 closed 1 year ago

davidcurrie2001 commented 1 year ago

When running the tests with dplyr v1.1.0 "test-removeBrokenSpeciesListLinks" failed with the following error:

Error (test-removeBrokenSpeciesListLinks.R:10): removeBrokenSpeciesListLinks runs without errors
          or warnings when there are no invalid species list links
<rlib_error_dots_nonempty/rlib_error_dots/rlang_error/error/condition>
Error in `dplyr::inner_join(myTable, objectToCheck[["SL"]], by = c(SSspecListName = "SLspeclistName", 
    SScatchFra = "SLcatchFrac", SSyear = "SLyear", SSctry = "SLcou"), 
    multiple = "all", relationship = "many-to-many")`: `...` must be empty.
✖ Problematic argument:
• relationship = "many-to-many"

After updating dplyr to v1.1.3 the tests passed. If the code is reliant on a minimum version of dplyr it should be stated - I've edited the Description file to:

Imports: 
    dplyr (>= 1.1.3), 
    data.table

(@rix133 this is a similar issue to #173)