search

ices-tools-dev / RDBEScore

Provides functions to work with the Regional Database & Estimation System (RDBES)
https://ices-tools-dev.github.io/RDBEScore/
GNU General Public License v3.0
0 stars 4 forks source link

test data h1_v_1_19 not valid #69

Closed nicholascarey closed 2 years ago

nicholascarey commented 2 years ago 
myH1RawObject <-
  createRDBESDataObject(rdbesExtractPath = "tests/testthat/h1_v_1_19")

validateRDBESDataObject(myH1RawObject)
> validateRDBESDataObject(myH1RawObject)
[1] "The following required columns are missing from table SS : SStimeTotal,SStimeSamp"
[1] "The following required columns are missing from table CL : CLdSoucstatRect,CLfishAreaCat,CLfreshWatNam,CLeconZone,CLtotNumFish,CLsciWeightErrMeaValTyp,CLsciWeightErrMeaValFirst,CLsciWeightErrMeaValSecond,CLvalErrMeaValTyp,CLvalErrMeaValFirst,CLvalErrMeaValSecond,CLnumFishInCatchErrMeaValTyp,CLnumFishInCatchErrMeaValFirst,CLnumFishInCatchErrMeaValSecond,CLcom"
[1] "The following required columns are missing from table CE : CEsoucStatRect,CEfishAreaCat,CEfreshWatNam,CEeconZone,CEgearDim,CEnumFAD,CEnumSupVes,CEfishDaysErrMeaValTyp,CEfishDaysErrMeaValFirst,CEfishDaysErrMeaValSecond,CEconfiFlag,CEencrypVesIds "
[1] "objectToCheck contains the following tables which don't contain all required fields: SS,CL,CE"
[1] FALSE

Appears to be an invalid dataset. Is there any reason not to delete it?

davidcurrie2001 commented 2 years ago

Its in the format from last year (as are all the "x_v_1_19" folders). The x_v1_18 test data is also almost certainly invalid. I think its fine to delete these.

davidcurrie2001 commented 2 years ago

I've just deleted those.

nicholascarey commented 2 years ago

👍