false status during and after file screening

ices-tools-dev / esas

European Seabirds at Sea (ESAS) data model

https://esas-docs.ices.dk

Creative Commons Zero v1.0 Universal

3 stars 1 forks source link

false status during and after file screening #106

Closed nicolasvanermen closed 2 years ago

nicolasvanermen commented 2 years ago

Please see my latest 4 file screenings, there is only 1 erroneous screening (the first test file, screening 114), yet for the other 3 it says 'Screening fisnished, file is not valid to upload to the database'. The same problem was flagged before for screening 111.

To frame this: I started new file screenings, because it gave the same remark ('screening finished...') soon after pushing the screening button, and clicking through gave an error message assuming to believe something went wrong. But apparently, the screening was still continuing in the background. Can this be made more clear, with a message stating that the screening is ongoing?

Concluding:

[ ] Screenings 111, 113, 115 & 116 are OK but status states otherwise
[ ] While screening is ongoing, status says screening has finished and clicking through gives an error, which is highly confusing!

nicolasvanermen commented 2 years ago

Printscreens while RSPB datafile is screening (or this is what I assume) - so there is no more false 'screening has finished' message, but no message saying 'screening is ongoing' either, and clicking through gives an error page. Also, all files are valid, but only for some there is a message saying this...

cmspinto commented 2 years ago

I belive this has been tackled:

nicolasvanermen commented 2 years ago

No it isn't, see file screening 122, file is valid but no message saying it is, and for files with induced errors there is no message stating it is invalid. Unchecked the bullets in original messages as the issues are either not solved (first bullet) or not checked properly (second bullet)

cmspinto commented 2 years ago

nicolasvanermen commented 2 years ago

cmspinto commented 2 years ago

I think you are correct, in the list of the file screenings there is a discrepancy between some of the messages in the valid files. Some have an info message and some don't. This is a field that is saved to the database when the file is screened.
I don't know where the discrepancy comes from, it could have to do with the fact if the user waited until de end of the screening.

Will change this field to be calculated in the fly and this way there should be no more discrepancy in the fields.