Checks on Latitude-Longitude & Distance-Area & links between tables

ices-tools-dev / esas

European Seabirds at Sea (ESAS) data model

https://esas-docs.ices.dk

Creative Commons Zero v1.0 Universal

3 stars 1 forks source link

Closed nicolasvanermen closed 2 years ago

nicolasvanermen commented 2 years ago

[x] Values outside the specified range should give errors in case of Latitude and Longitude
[x] There should be a cross check for Distance & Area (at least one should hold a positive value)
[x] Turning Distance into float(6) should coincide with a specified range Lower:0.000100000000 Upper: 9999.000000000000, as in Area #102
[x] There should be a check of the links between the tables (are all CampaignID's in Samples present in Campaigns, etcetera...) (see issue 117 and file screening 128)

peterdesmet commented 2 years ago

@Osanna123 can you implement these checks? Would be good that they are implemented before testing the full upload.

peterdesmet commented 2 years ago

Should also be tested with a file that purposefully contains errors (cf. #117).

neil-ices-dk commented 2 years ago

Anna is working on this, in progress

neil-ices-dk commented 2 years ago

Implemented; tested but @Osanna123 to test "Values outside the specified range should give errors in case of Latitude and Longitude"

Osanna123 commented 2 years ago

done