API returns samples from restricted campaigns

[peterdesmet]

This is a restricted campaign: https://esas.ices.dk/api/getCampaignRecords?campaignID=19910813112

[
  {
    "tblUploadID": 232,
    "tblCampaignID": 209012,
    "dataRightsHolder": "5045",
    "country": "NL",
    "campaignID": "19910813112",
    "dataAccess": "Restricted",
    "startDate": "1991-08-13",
    "endDate": "1991-08-13",
    "notes": null
  }
]

• [x] It assume it is normal that I (public user) can query for the existence of this campaign? @nicolasvanermen
• [x] I should probably not be able to query for samples within this campaign? @nicolasvanermen Currently I can: https://esas.ices.dk/api/getSampleRecords?campaignID=19910813112 @cmspinto can you fix this?
• [x] I cannot query for positions in the campaign, which is expected: https://esas.ices.dk/api/getPositionRecords?campaignID=19910813112
• [x] I cannot query for observations in the campaign, which is expected: https://esas.ices.dk/api/getObservationRecords?campaignID=19910813112

[nicolasvanermen]

I don't think this has ever been talked through but besides from that I am not against being able to query for restricted data sample records... I might give some insight in the type of data (platform type, counting method, ...) which in turn may determine whether not to request data.

[peterdesmet]

But what do you the data owners of such data expect? I think it is clearer to communicate that only campaign info is publicly available?

[nicolasvanermen]

Yes that is indeed more straightforward.

[peterdesmet]

@cmspinto can you implement this as such (don’t return samples from restricted campaigns).

[cmspinto]

Fixed, thanks for the heads up. This was a bug in the getSamples for the API. https://esas.ices.dk/api/getSampleRecords?campaignID=19910813112

If the user is a manager of the Organization it can download these records using JWT authentication.