search

ices-tools-dev / esas

European Seabirds at Sea (ESAS) data model
https://esas-docs.ices.dk
Creative Commons Zero v1.0 Universal
3 stars 1 forks source link

test request restricted data #133

Open nicolasvanermen opened 2 years ago

nicolasvanermen commented 2 years ago

@cmspinto: could you link the Bureau Waardenburg data to Ruben Fijn (r.c.fijn@buwa.nl) so I can test whether he can unlock the data and I can download their data?

cmspinto commented 2 years ago

Yes, that would be a good idea. I think @Osanna123 found a few typos that we will correct in the email(s).

nicolasvanermen commented 2 years ago

Has Ruben been linked as contact person to the BuWa data? And if not, who is?

cmspinto commented 2 years ago

No, currently there is only one user that is linked to an institution, it's you: image

Either you can insert the link between the users and the institutes or you can send me the list and I can do it.

In the case of Ruben what is his user name or email?

nicolasvanermen commented 2 years ago

His email is r.c.fijn@buwa.nl, but I don't think he has an account nor a username at ICES. Should he request this himself before we can continue? And who should he be contacting?

nicolasvanermen commented 1 year ago

Hi Carlos, can you guide me through this...? See the printscreen, this a request regarding restricted data (so BuWa data). Yet the data rights holder for this request is flagged INBO (code 202), while I guess it should be BuWa. But since it is flagged INBO, I think it is strange that the contact is not me but you. Can you tell what is going wrong here?

image

cmspinto commented 1 year ago

Hi Nicolas, there is a bug and will get back to that. I put myself as manager of BUWA, maybe we could ask Rubin to get an ICES user so he can manage the request himself?

image

cmspinto commented 1 year ago

Hi Nicolas,

There was a bug in the query and all the managers of institutes (that were part of the request) could view the request, no matter if there was restricted or public data. For that is the reason you could see and were listed as part of the request!

In summary, when extracting the institutes that had restricted data, it was extracting all the institutes instead, filter is now in place to only the institutes that have restricted data will be able to see the request, can you check?

image

This still needs more testing, if there is another institute uploading restricted data then we should take the opportunity to test and develop further this feature.

nicolasvanermen commented 1 year ago

Indeed, now I get an empty list, as expected. I sent an email so Ruben can receive an account.

image

nicolasvanermen commented 10 months ago

Hello Carlos, I received an email from Job De Jong of Bureau Waardenburg. They would like to get an export for their own data, but Ruben did not get an email to approve the use and export of their restricted data. How can we set this straight? They plan to upload data this spring so we should really try to encourage them as much as possible. Thanks! Nicolas

cmspinto commented 10 months ago

Hi Nicolas, if I found the right email of Job de Jong, he should now have access to the requests for Bureau Waardenburg:

image

Let's try to go step by step:

Login here https://esas.ices.dk/manage/ and choose the option "View list of your restricted data requests":

image

Here he will see a list of all the request for his organization:

image

And yes, the last one was himself doing the request (so I can see I got correctly his email):

image

I hope that I was clear and gave a good description, but any question or comments are very welcome.

Note: Another option is to download the data of Bureau Waardenburg using the webservices. In case he authenticates using JWT, when requesting the data using the webservices, since he is the administrator of Bureau Waardenburg the data will be included in the download using the webservices.

nicolasvanermen commented 10 months ago

OK, thank you very much for the quick follow-up Carlos, I will forward this to Job and await his response. As I understand this is a workaround for the bug in the workflow concerning restricted data requests, right? Good for now though, and let's try to fix this issue some time in the coming months... Have a nice 2024! Nicolas

cmspinto commented 10 months ago

Hi Nicolas,

A good 2024 for you.

I'm not sure what you mean by suggesting there is a bug. This represents the workflow of the requests made on restricted data.

nicolasvanermen commented 10 months ago

Well I assumed there to be a bug since Ruben mentions he never received my (test) data request, nor the request of Job... Yet Job de Jong notified that all went well... So what went wrong in first instance? Maybe Ruben does still not have an ICES account, could that be the problem?