updated ESAS species coding

ices-tools-dev / esas

European Seabirds at Sea (ESAS) data model

https://esas-docs.ices.dk

Creative Commons Zero v1.0 Universal

3 stars 1 forks source link

updated ESAS species coding #97

Closed nicolasvanermen closed 2 years ago

nicolasvanermen commented 2 years ago

Please add or adjust the following to the ESAS coding list:

peterdesmet commented 2 years ago

@cmspinto or @Osanna123 this issue requests updates to the species list in the database:

[x] Add a new taxon 126, cf. https://github.com/ices-tools-dev/esas/commit/290ece350197cb24f46d86b156420929318f6018

esas_code: 126
scientific_name: Podiceps grisegena / auritus
english_name: Red-necked / Slavonian Grebe
euring_code:
euring_scientific_name:
aphia_id: 137056
aphia_scientific_name: Podiceps
remarks:

[x] Update taxon 6169 to 6159, cf. https://github.com/ices-tools-dev/esas/commit/e480f3f9b2dca2eab5a3bf1d7d3613dd18b29c83

esas_code: 6159 # not 6169
scientific_name: Sterna hirundo / paradisaea
english_name: Common / Arctic Tern
euring_code: 06159 # new
euring_scientific_name: Sterna hirundo/paradisaea # new
aphia_id: 137047
aphia_scientific_name: Sterna
remarks:

@nicolasvanermen rather than screenshots, it is easier if you (also) include the URL to the commit in the issue.

Osanna123 commented 2 years ago

Are you sure that the EURING code 06159 for the ESAS code 6159 is correct? it seems to be the first case of the leading zeroes in EURING codes.

JochemBoersma commented 2 years ago

EURING codes are always 5 digits, i.e. with leading zero's. ESAS codes aren't.

(fyi: I'm following this repo, for mapping between EURING and ESAS codes for bird observations for WoZEP)

peterdesmet commented 2 years ago

I confirm that is correct.

neil-ices-dk commented 2 years ago

@cmspinto to add leading zero's in the EURING codes in the database

cmspinto commented 2 years ago

Done

neil-ices-dk commented 2 years ago

implemented, but we should discuss this in terms of governance (JWGBIRDS) that the approach is not a good one for transparency, and could be aligned

peterdesmet commented 2 years ago

we should discuss this in terms of governance (JWGBIRDS) that the approach is not a good one for transparency,

Can you clarify what "approach" you are referring to? The approach of having leading zeros?

cmspinto commented 2 years ago

The approach that @neil-ices-dk is referring is to have manual update of a table in the database of the link between AphiaID, EURING codes and ESAS Codes.

In the next sprint we can discuss alternatives to that.