search

ices-tools-prod / TAF

Transparent Assessment Framework for Reproducible Research
GNU General Public License v3.0
3 stars 2 forks source link

Possible issue in detach.packages() when trying to detach a package which is depended on by a loaded package #5

Open colinpmillar opened 2 years ago

colinpmillar commented 2 years ago

https://github.com/ices-tools-prod/TAF/blob/0e7c09f52a79ecd84c60d99ab3682e5942fcd464/R/detach.packages.R#L30

arni-magnusson commented 3 days ago

The 'detach' argument in source.taf(), defaulting to FALSE is something I haven't used or tested much. It looks we added that feature back in April 2020, so it probably seemed like a good idea at the time :)

Happy to look at a reproducible example and/or talk about possible improvements. Currently, I don't have test cases where detach=TRUE can be helpful or harmful.

My guess is that few people run source.taf() with detach=TRUE, but I notice that taf=TRUE enables detach=TRUE. Does that mean that the TAF server runs all analyses with detach=TRUE?