search

ices-tools-prod / icesSAG

R interface to Stock Assessment Graphs database web services
http://sg.ices.dk/webservices.aspx
10 stars 7 forks source link

Strange result with Bass #194

Closed timearl closed 4 years ago

timearl commented 4 years ago

I'm trying to extract the stock assessment for bass, and an empty vector is returned. If I truncate the stock id, it can be found. Minimal example below

library(icesSAG)
findAssessmentKey("bss.27.4bc7ad–h", published=TRUE)
# integer(0)

findAssessmentKey("bss.27.4bc7ad", published=TRUE)
# [1]  9207  9959 12957

> findAssessmentKey("bss.27.4bc7ad", published=TRUE, full=TRUE)$StockKeyLabel
# [1] "bss.27.4bc7ad-h" "bss.27.4bc7ad-h" "bss.27.4bc7ad-h"
colinpmillar commented 4 years ago

thanks Tim - it looks like a bug in the search we are doing in the package

colinpmillar commented 4 years ago

So it was an issue with long dash: – verses short dash -

> "bss.27.4bc7ad–h" == "bss.27.4bc7ad-h"
[1] FALSE
>

The quick fix is to change the stock name in your code to the correct name (i.e. not use the long dash).

But we will also put in a catch in the findAssessmentKey to fix this as it could well be a common issue.

THanks, Colin

colinpmillar commented 4 years ago

check and fix implemented here: https://github.com/ices-tools-prod/icesSAG/commit/f8ef7044dec63061ed2d97f11b22b0b5dc66d244

thanks for letting us know, Colin

timearl commented 4 years ago

Thanks Colin for looking into this and fixing it, it’s much appreciated.

Tim

From: Colin Millar notifications@github.com Sent: 29 October 2019 10:03 To: ices-tools-prod/icesSAG icesSAG@noreply.github.com Cc: Timothy Earl (Cefas) timothy.earl@cefas.co.uk; Author author@noreply.github.com Subject: Re: [ices-tools-prod/icesSAG] Strange result with Bass (#194)

So it was an issue with long dash: – verses short dash -

"bss.27.4bc7ad–h" == "bss.27.4bc7ad-h"

[1] FALSE

The quick fix is to change the stock name in your code to the correct name (i.e. not use the long dash).

But we will also put in a catch in the findAssessmentKey to fix this as it could well be a common issue.

THanks, Colin

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fices-tools-prod%2FicesSAG%2Fissues%2F194%3Femail_source%3Dnotifications%26email_token%3DABKX6B62V6RFLTPIOABMTOLQRAC6JA5CNFSM4I2NN6PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECP5FJQ%23issuecomment-547345062&data=02%7C01%7C%7Cd5865abf76144af0544208d75c57390a%7Ceeea3199afa041ebbbf2f6e42c3da7cf%7C0%7C0%7C637079402001853492&sdata=SvPd2KNSAlsKNVrBVeMKwg%2Fit3coUbMEzhaa2XiFluE%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABKX6BZYN3LIYQ55ZCWLGN3QRAC6JANCNFSM4I2NN6PA&data=02%7C01%7C%7Cd5865abf76144af0544208d75c57390a%7Ceeea3199afa041ebbbf2f6e42c3da7cf%7C0%7C0%7C637079402001863484&sdata=UNMeYOU5XfG3%2F7fnsqwR7pEW7i02PmgfQJEBTRD4PAI%3D&reserved=0.

This email and any attachments are intended for the named recipient only. Its unauthorised use, distribution, disclosure, storage or copying is not permitted. If you have received it in error, please destroy all copies and notify the sender. In messages of a non-business nature, the views and opinions expressed are the author's own and do not necessarily reflect those of Cefas. Communications on Cefas’ computer systems may be monitored and/or recorded to secure the effective operation of the system and for other lawful purposes. All messages sent and received by the Centre for Environment, Fisheries and Aquaculture Science may be monitored in line with relevant UK legislation . https://www.gov.uk/government/organisations/centre-for-environment-fisheries-and-aquaculture-science/about/personal-information-charter