Closed colinpmillar closed 3 years ago
R/findAssessmentKey.R:39:6: style: Commented code should be removed.
#stock <- gsub(EmDash, "-", stock)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/getGraph.R:85:1: style: Variable and function names should not be longer than 30 characters.
getFishingMortalityHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/getGraph.R:89:1: style: Variable and function names should not be longer than 30 characters.
getRecruitmentHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/SAGxml.R:54:1: style: Lines should not be more than 120 characters.
"<Assessment xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='ICES_Standard_Graphs.xsd'>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/utilities.R:248:1: style: functions should have cyclomatic complexity of less than 15, this has 20.
simplify <- function(x) {
^
R/findAssessmentKey.R:39:6: style: Commented code should be removed.
#stock <- gsub(EmDash, "-", stock)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/getGraph.R:85:1: style: Variable and function names should not be longer than 30 characters.
getFishingMortalityHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/getGraph.R:89:1: style: Variable and function names should not be longer than 30 characters.
getRecruitmentHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/SAGxml.R:54:1: style: Lines should not be more than 120 characters.
"<Assessment xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='ICES_Standard_Graphs.xsd'>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/utilities.R:248:1: style: functions should have cyclomatic complexity of less than 15, this has 20.
simplify <- function(x) {
^
R/getGraph.R:85:1: style: Variable and function names should not be longer than 30 characters.
getFishingMortalityHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/getGraph.R:89:1: style: Variable and function names should not be longer than 30 characters.
getRecruitmentHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/SAGxml.R:54:1: style: Lines should not be more than 120 characters.
"<Assessment xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='ICES_Standard_Graphs.xsd'>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/utilities.R:248:1: style: functions should have cyclomatic complexity of less than 15, this has 20.
simplify <- function(x) {
^
R/getGraph.R:85:1: style: Variable and function names should not be longer than 30 characters.
getFishingMortalityHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/getGraph.R:89:1: style: Variable and function names should not be longer than 30 characters.
getRecruitmentHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/SAGxml.R:54:1: style: Lines should not be more than 120 characters.
"<Assessment xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='ICES_Standard_Graphs.xsd'>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/utilities.R:248:1: style: functions should have cyclomatic complexity of less than 15, this has 20.
simplify <- function(x) {
^
addresses #204