lintr-bot
commented
3 years ago R/getGraph.R:85:1: style: Variable and function names should not be longer than 30 characters.
getFishingMortalityHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/getGraph.R:89:1: style: Variable and function names should not be longer than 30 characters.
getRecruitmentHistoricalPerformance <- getLandingsGraph
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/SAGxml.R:54:1: style: Lines should not be more than 120 characters.
"<Assessment xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='ICES_Standard_Graphs.xsd'>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/utilities.R:248:1: style: functions should have cyclomatic complexity of less than 15, this has 19.
simplify <- function(x) {
^R/utilities.R:260:3: style: Opening curly braces should never go on their own line and should always be followed by a new line.
{
^R/utilities.R:264:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.
{
^R/utilities.R:272:3: style: Opening curly braces should never go on their own line and should always be followed by a new line.
{
^R/utilities.R:276:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.
{
^R/utilities.R:282:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.
{
^
One solution to issue https://github.com/ices-tools-prod/icesSAG/issues/213