Closed hgerritsen closed 2 years ago
Milldaz
commented
2 years ago Hi Hans, I have checked and there is no filter excluding non-Advice assessments from the download. In 2022 there are only two assessments for ank.27.78abd - 'Bench' and 'Advice'.
hgerritsen
commented
2 years ago Hi David Then how do I get the 2022 summary table? None of these work:
library(icesSAG)
getSAG('ank.27.78abd',2021,data='summary',purpose='Advice')
getSAG('ank.27.78abd',2022,data='summary',purpose='Advice')
getSAG('ank.27.78abd',2022,data='summary',purpose='InitAdvice')
getSAG('ank.27.78abd',2022,data='summary',purpose='Bench')
cat("# Standard Graphs personal access token", "SG_PAT=d0316196-6c9b-4f00-b3a2-ec1c0ec1be19", sep = "\n", file = "~/.Renviron_SG") options(icesSAG.use_token = TRUE)
getSAG('ank.27.78abd',2022,data='summary',purpose='Advice')
getSAG('ank.27.78abd',2022,data='summary',purpose='InitAdvice')
getSAG('ank.27.78abd',2022,data='summary',purpose='Bench')
Thanks, Hans
From: David Miller @. Sent: Thursday 12 May 2022 09:07 To: ices-tools-prod/icesSAG @.> Cc: Hans Gerritsen @.>; Author @.> Subject: Re: [ices-tools-prod/icesSAG] Cannot download summary of initial advice (Issue #225)
Hi Hans, I have checked and there is no filter excluding non-Advice assessments from the download. In 2022 there are only two assessments for ank.27.78abd - 'Bench' and 'Advice'.
— Reply to this email directly, view it on GitHubhttps://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fices-tools-prod%2FicesSAG%2Fissues%2F225%23issuecomment-1124663776&t=aa801397fc78f30b446004173219bd56651617b9, or unsubscribehttps://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHA5GPIM6JCFRJLAQK4D6HLVJS33FANCNFSM5VOOECPQ&t=d4c2eee39f6c3b0ebf75c942b1a5717120e37396. You are receiving this because you authored the thread.Message ID: @.**@.>>
Milldaz
commented
2 years ago For me at least, this line gets both 2022 assessments: getSAG('ank.27.78abd',2022,data='summary')
It seems that the purpose parameter doesn't do anything actually, since I also get both assessments with either of these: getSAG('ank.27.78abd',2022,data='summary',purpose='Bench') getSAG('ank.27.78abd',2022,data='summary',purpose='Advice') getSAG('ank.27.78abd',2022,data='summary',purpose='InitAdvice')
colinpmillar
commented
2 years ago Hi all, Yes the purpose parameter (which should filter on purpose) seems not to have been implemented! So I will get onto that.
However, I also get a dataframe with Bench and Advice versions of the summary table for the 2022.
Maybe it is a package version issue?
Do you get anything when you look at the http pages from your browser?
hgerritsen
commented
2 years ago Hi Colin, David
The webservice works for me (with my own token). So the problem seems to be somewhere in the R function. I installed the lastest version of icesSAG (v 1.4.0) and I still get nothing for 2022 with or without the option icesSAG.use_token. Maybe it fails to identify the correct assessmentKey?
Hans
From: Colin Millar @. Sent: Thursday 12 May 2022 10:19 To: ices-tools-prod/icesSAG @.> Cc: Hans Gerritsen @.>; Author @.> Subject: Re: [ices-tools-prod/icesSAG] Cannot download summary of initial advice (Issue #225)
Hi all, Yes the purpose parameter (which should filter on purpose) seems not to have been implemented! So I will get onto that.
However, I also get a dataframe with Bench and Advice versions of the summary table for the 2022.
Maybe it is a package version issue?
Do you get anything when you look at the http pages from your browser?
https://sg.ices.dk/Manage/StockAssessmentGraphsWithToken.asmx/getSummaryTable?assessmentKey=17280&token=https://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fsg.ices.dk%2FManage%2FStockAssessmentGraphsWithToken.asmx%2FgetSummaryTable%3FassessmentKey%3D17280%26token%3D&t=1c897aa14e9cb0aee36ddba44f8377e22cb9e39b<pastehttps://sg.ices.dk/Manage/StockAssessmentGraphsWithToken.asmx/getSummaryTable?assessmentKey=17280&token=%3cpaste<https://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fsg.ices.dk%2FManage%2FStockAssessmentGraphsWithToken.asmx%2FgetSummaryTable%3FassessmentKey%3D17280%26token%3D%253cpaste&t=70f1cc019ea7bdb106f53f6631f9c391566a5643> your token here>
From: David Miller @.<mailto:@.>> Sent: 12 May 2022 11:15 To: ices-tools-prod/icesSAG @.<mailto:@.>> Cc: Subscribed @.<mailto:@.>> Subject: Re: [ices-tools-prod/icesSAG] Cannot download summary of initial advice (Issue #225)
For me at least, this line gets both 2022 assessments: getSAG('ank.27.78abd',2022,data='summary')
It seems that the purpose parameter doesn't do anything actually, since I also get both assessments with either of these: getSAG('ank.27.78abd',2022,data='summary',purpose='Bench') getSAG('ank.27.78abd',2022,data='summary',purpose='Advice') getSAG('ank.27.78abd',2022,data='summary',purpose='InitAdvice')
— Reply to this email directly, view it on GitHubhttps://github.com/ices-tools-prod/icesSAG/issues/225#issuecomment-1124730864<https://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fices-tools-prod%2FicesSAG%2Fissues%2F225%23issuecomment-1124730864&t=5a6589078fb5768e569b8d4b393ec9df9044dfb9>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALO5AEC5HW6WJ7HYW2YE5LVJTDZDANCNFSM5VOOECPQ<https://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAALO5AEC5HW6WJ7HYW2YE5LVJTDZDANCNFSM5VOOECPQ&t=e0fc848bc135ec837c4c6b2206ca49ee6829fb41>. You are receiving this because you are subscribed to this thread.Message ID: @.**@.mailto:***@***.******@***.***>>
— Reply to this email directly, view it on GitHubhttps://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fices-tools-prod%2FicesSAG%2Fissues%2F225%23issuecomment-1124734805&t=567df0d3de73db01f024a8f95c2f92876983a426, or unsubscribehttps://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHA5GPIVR5Y6V5JWTRSQY6TVJTEJLANCNFSM5VOOECPQ&t=12d4003fb1857e35cd4378751b43ae3bf19aa06f. You are receiving this because you authored the thread.Message ID: @.**@.>>
LApetre
commented
2 years ago Hi all, There was actually an issue with one of the web service methods (stock list method not summary data) that could be related to this. That is fixed now. Could you give the R method another try Hans and let us know if that helped? Best, Laura
hgerritsen
commented
2 years ago Yes, it worked! Thanks all. Hans
From: Laura Petre @. Sent: Thursday 12 May 2022 12:02 To: ices-tools-prod/icesSAG @.> Cc: Hans Gerritsen @.>; Author @.> Subject: Re: [ices-tools-prod/icesSAG] Cannot download summary of initial advice (Issue #225)
Hi all, There was actually an issue with one of the web service methods (stock list method not summary data) that could be related to this. That is fixed now. Could you give the R method another try Hans and let us know if that helped? Best, Laura
— Reply to this email directly, view it on GitHubhttps://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fices-tools-prod%2FicesSAG%2Fissues%2F225%23issuecomment-1124853851&t=bc73f4fa54d604f8fafdbb31efe4bb2f8ba5667a, or unsubscribehttps://scanner.topsec.com/?d=1076&r=show&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHA5GPL6HXLJYJIYKUQVUMDVJTQKXANCNFSM5VOOECPQ&t=1b02dc891134a47364ba2b58d114e1cb7d993243. You are receiving this because you authored the thread.Message ID: @.**@.>>
It doesnt seem to be possible to download initial advice, I can only get published advice, even when i used the same token that i used to upload the data