ASD TO DOs

[LApetre]

• [x] Add the “download template” button also to the main page after the user logs in. This would help getting the template quicker.
• [x] Add AdviceComponent field to Advice view for cases where there are 2/more advice views per sag entry
• [x] Save Jwt token on Advice view and pass to download controller
• [x] If the url does not start with asd redirect to asd on page
• [x] Change the name of the template to CatchScenarioTable

[LApetre]

Change text on ASD pages:

1. Changes needed on Advice list site AdviceList - Advice View (ices.dk)
   • [x] Replace:

“Here you can find the advice values, and catch options table from ICES fish stock assessments as presented in published advice. You can:” With: “Here you can find the advice values and catch scenarios tables from ICES fish stock assessments as presented in the published advice.”

• [x] Replace:

“In this page you can see all your submissions to the database:” with: “Filter advice by:”

• [x] Change column header “Advice Released Date” to “Publication Date”

2. Changes needed on the Manage page index - Advice View (ices.dk)

• [x] 1. Replace:

“Here you can find the advice values, and catch options table from ICES fish stock assessments as presented in published advice. You can:” With: “Here you can upload and edit the advice information and catch scenarios tables from ICES fish stock assessments.”

• [x] 2. Replace:

“Summaries available for the Assessment Year of:” With: “Advice records available for the Assessment Year:”

• [x] 3. Replace:

“List of Stock assessment already with Advice View Records:” With: “List of stock assessments with advice records:”

• [x] 4. Replace:

“List of Stock assessment that don't have any Advice View Records:” With: “List of stock assessments without advice records:”

[Milldaz]

• [ ] For 'NoAdv' stocks, other fields should not be 'required'

• [ ] Add common name to 'Species' select list: Common name (scientific name) -https://sid.ices.dk/Manage/ManageStock.aspx?id=3245 ("Species Scientific Name" and "Species Common Name")

• [x] Only allow a entry to be published if there is an Advice Release Date, and the current date is later than this (after 12h00 on the day of release).

• [x] Change "catch option table" to "catch scenario table", see https://asd.ices.dk/viewAdvice/1093 as an example

[colinpmillar]

Issues encountered developing the R interface

• [ ] download xml form the edit page returns truncated notes feild - 20 characters.
• [x] this webservice returns unpublished records (including the headline advice) https://asd.ices.dk/API/getAdviceViewRecord?stockcode=her.27.3a47d&year=2023 - fixed
• [ ] database contains non-utf8 characters in the notes and label feilds. These characters are returned in the webservice and in the download XML handler. an example:
  • https://asd.ices.dk/API/getCatchScenariosTable/3207 Fprojected landings (ages 2–4) - the dash is no utf8
  • issue here is that R and other consumers need to know the text encoding, and also that the xml header states utf8.
  • <?xml version="1.0" encoding="utf-8" standalone="no"?>
• [x] adviceDownload service: returns in a zip - fixed
  • Data_24_04_2023_13_46.csv - the links in this point to sag.ices.dk still
  • CatchScenarios_AdviceKey_1009_24_04_2023_13_46.csv - this file is empty.

requests:

• [x] REQUEST: can there be a webservice to download the xml file? There is: GET request at link https://asd.ices.dk/API/DownloadCatchScenariosXML/{advicekey} Need to provide jwt token if the advice record is not published

• [x] REQUEST: if a token is provided can we access catch options etc of unpublished records?

Otherwise all very cool :)