search

ices-tools-prod / icesTAF

Functions to support the ICES Transparent Assessment Framework
GNU General Public License v3.0
5 stars 7 forks source link

Bug in parsing sha code #13

Closed colinpmillar closed 4 years ago

colinpmillar commented 4 years ago

bug is here: https://github.com/ices-tools-prod/icesTAF/blob/833619df32597cb3d0ba58c2cada4b4b068732ea/R/get.remote.sha.R#L35-L36

in windows at least, n = 2 does nothing. The url returns a single string, which needs to be parse by a json parser - as in the original pull request:

https://github.com/ices-tools-prod/icesTAF/pull/9/commits/8e2090100de17170a855522aeace52731f711be2

arni-magnusson commented 4 years ago

Fixed in 132e6ba.