search

ices-tools-prod / icesTAF

Functions to support the ICES Transparent Assessment Framework
GNU General Public License v3.0
5 stars 7 forks source link

Problem with function isFALSE with R < 3.5 #5

Closed alko989 closed 5 years ago

alko989 commented 5 years ago

The function isFALSE was introduced in R version 3.5 but there is no such requirement in the package DESCRIPTION.

I suggest to use identical(period, FALSE) in this line instead of requiring the latest version of R.

NOTE: I checked the latest R base and isFALSE is defined as isFALSE <- function(x) is.logical(x) && length(x) == 1L && !is.na(x) && !x

so another option is to add this line somewhere if(!exists("isFALSE")) isFALSE <- function(x) is.logical(x) && length(x) == 1L && !is.na(x) && !x

arni-magnusson commented 5 years ago

Great idea, thanks! Fixed in commit 3232994.