icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
207 stars 106 forks source link

update cloud tutorial to work with publicly accessible cloud data #381

Closed JessicaS11 closed 1 year ago

JessicaS11 commented 1 year ago

The goal here was to get the data access notebook working in time for the Oct 2022 IS2 Science Team meeting. This PR updates granules to get the s3 urls directly from the CMR metadata rather than constructing them manually, and the CMR metadata are queried specifically for cloud data (which is identical to the on-premises data that you would download from NSIDC). It does not yet address simplifications to the authentication process (planned with the introduction of earthaccess, currently still packaged as earthdata).

NOTE: this PR will need to be merged after #331, at which point this branch should be selectively rebased to streamline the review).

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on this branch for commit 0786e1c523107ba0f89f6d7da735a4ffad2548dd

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit fadbebeb45e7b376c9da17db4ce46eeef6b136e6

Binder :point_left: Launch a binder notebook on this branch for commit db717b26ae121882ad6c620c50cb87ae3a4400c8

codecov-commenter commented 1 year ago

Codecov Report

Base: 57.51% // Head: 57.42% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (db717b2) compared to base (dfa21eb). Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #381 +/- ## =============================================== - Coverage 57.51% 57.42% -0.10% =============================================== Files 31 29 -2 Lines 2248 2243 -5 Branches 431 433 +2 =============================================== - Hits 1293 1288 -5 + Misses 873 872 -1 - Partials 82 83 +1 ``` | [Impacted Files](https://codecov.io/gh/icesat2py/icepyx/pull/381?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py) | Coverage Δ | | |---|---|---| | [icepyx/core/granules.py](https://codecov.io/gh/icesat2py/icepyx/pull/381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py#diff-aWNlcHl4L2NvcmUvZ3JhbnVsZXMucHk=) | `38.86% <62.50%> (+0.88%)` | :arrow_up: | | [icepyx/core/query.py](https://codecov.io/gh/icesat2py/icepyx/pull/381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py#diff-aWNlcHl4L2NvcmUvcXVlcnkucHk=) | `50.21% <100.00%> (ø)` | | | [icepyx/\_\_init\_\_.py](https://codecov.io/gh/icesat2py/icepyx/pull/381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py#diff-aWNlcHl4L19faW5pdF9fLnB5) | | | | [icepyx/conftest.py](https://codecov.io/gh/icesat2py/icepyx/pull/381/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py#diff-aWNlcHl4L2NvbmZ0ZXN0LnB5) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.