icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
207 stars 106 forks source link

update oa viz for polygons after spatial module change #390

Closed JessicaS11 closed 1 year ago

JessicaS11 commented 1 year ago

OpenAltimetry visualizations could not be requested for polygon spatial extents due to a missed type change required by the introduction of the spatial module and cross-dateline handling in #331.

The bug was originally documented here, and an inline fix can be found here.

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on this branch for commit be0527ae1df8e8866315d8b15bf7ad723cb37e3c

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit c9d8cfdc8f7705d64a10b83344b297c6fca0830f

Binder :point_left: Launch a binder notebook on this branch for commit bfdaed7b3215b30fb4affc0aa753c7acee2f13d9

Binder :point_left: Launch a binder notebook on this branch for commit 84577af3659f846cc8402cd2918b459fa277846a

Binder :point_left: Launch a binder notebook on this branch for commit 4eea849f22d42141e9fb268b6b3864665b87f7cd

Binder :point_left: Launch a binder notebook on this branch for commit 9601a42d48a4de2327654acb6c530ebd813396b1

Binder :point_left: Launch a binder notebook on this branch for commit a913b24fb2eabdfe14b4d0ec289bdfbfb71fd4c3

Binder :point_left: Launch a binder notebook on this branch for commit f9af8c9e4882b78a74c7c09353e3b4e9574815cc

Binder :point_left: Launch a binder notebook on this branch for commit 19a9e1e27c5848ea9a95dc0898f3ced9b66aaceb

JessicaS11 commented 1 year ago

I'm still working on debugging the tests. The failure is coming from ATL13 queries that return no data (at the CMR query stage).

UPDATE: I'm working with NSIDC on this, but there's no clear explanation for what happened (the tests started failing seemingly randomly on 7 Nov). So we can move ahead with this PR and the important fix it contains, I've deactivated the tests and opened #399.

codecov-commenter commented 1 year ago

Codecov Report

Base: 57.57% // Head: 58.29% // Increases project coverage by +0.72% :tada:

Coverage data is based on head (19a9e1e) compared to base (6d7dde9). Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #390 +/- ## =============================================== + Coverage 57.57% 58.29% +0.72% =============================================== Files 31 31 Lines 2251 2247 -4 Branches 433 433 =============================================== + Hits 1296 1310 +14 + Misses 872 854 -18 Partials 83 83 ``` | [Impacted Files](https://codecov.io/gh/icesat2py/icepyx/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py) | Coverage Δ | | |---|---|---| | [icepyx/core/visualization.py](https://codecov.io/gh/icesat2py/icepyx/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py#diff-aWNlcHl4L2NvcmUvdmlzdWFsaXphdGlvbi5weQ==) | `73.17% <0.00%> (+10.07%)` | :arrow_up: | | [icepyx/tests/test\_visualization.py](https://codecov.io/gh/icesat2py/icepyx/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py#diff-aWNlcHl4L3Rlc3RzL3Rlc3RfdmlzdWFsaXphdGlvbi5weQ==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.