icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
207 stars 106 forks source link

update read-in module for ATL11 #398

Closed JessicaS11 closed 1 year ago

JessicaS11 commented 1 year ago

The read-in module was not working for ATL11. This PR aims to remedy that.

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on this branch for commit 76576ae11daccc2177ea7bf660a2294d3c091d1e

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 31594a913b46a8ce0861ab1fbb3f3c186ae2a346

Binder :point_left: Launch a binder notebook on this branch for commit 79c4b7ceeee6568c1b36a01ee9cd7a7227406545

Binder :point_left: Launch a binder notebook on this branch for commit 92267378ecdc4a578f8633d4dcf1b5db01d77db3

Binder :point_left: Launch a binder notebook on this branch for commit 35088baaac04f0fc378da1f0c5d4b967f256975e

Binder :point_left: Launch a binder notebook on this branch for commit 191851ff09e776ba211362f02eed04b5355c8647

Binder :point_left: Launch a binder notebook on this branch for commit 5b2da3ad3fe0e7a7dfc21f0b039ebf66068b0405

Binder :point_left: Launch a binder notebook on this branch for commit 1b269789e29a15aa8d8f426e1d58f6b4c84b99cd

Binder :point_left: Launch a binder notebook on this branch for commit 8568fae6bb15043edf27e7a6855245f4903461d5

Binder :point_left: Launch a binder notebook on this branch for commit 45540cef2d298e9f00a8eb2da2600a9e22dac9cd

Binder :point_left: Launch a binder notebook on this branch for commit 03befa0fa6dce211da359c40f1adb57819461203

Binder :point_left: Launch a binder notebook on this branch for commit dfaf2e9a2f09e6209fee53630683f2150e59c1f2

Binder :point_left: Launch a binder notebook on this branch for commit 775dba1384b3dc5c3c05dea61c606fa305d39dbb

Binder :point_left: Launch a binder notebook on this branch for commit bf6e632a1287044b2921511bb212f258d1e0f42f

chris-picard commented 1 year ago

Hi Jessica, when trying to pull ATL11 using icepyx, I kept getting an error "pop from empty list":

#get a list of granule IDs for the available granules
region_a.avail_granules(ids=True) 

Which returned the error message:

IndexError                                Traceback (most recent call last)
/var/folders/d2/jjjzv8t95113nztdlt260q8r0000gn/T/ipykernel_14830/3270823387.py in <module>
      1 #get a list of granule IDs for the available granules
      2 print(region_a.CMRparams)
----> 3 region_a.avail_granules(ids=True)

~/opt/anaconda3/lib/python3.9/site-packages/icepyx/core/query.py in avail_granules(self, ids, cycles, tracks, s3urls)
    907         if ids or cycles or tracks or s3urls:
    908             # list of outputs in order of ids, cycles, tracks, s3urls
--> 909             return granules.gran_IDs(
    910                 self.granules.avail,
    911                 ids=ids,

~/opt/anaconda3/lib/python3.9/site-packages/icepyx/core/granules.py in gran_IDs(grans, ids, cycles, tracks, dates, s3urls)
    107                 AUX,
    108                 SFX,
--> 109             ) = rx.findall(producer_granule_id).pop()
    110             gran_cycles.append(CYCL)
    111             gran_tracks.append(TRK)

IndexError: pop from empty list

I ran this identical code for ATL06 and ATl12 without any issues. It seems like there is an issue with identifying the ID's of granules for ATL11. I have adjusted the spatial boundaries and maximized the temporal ones to make sure that I am getting enough data -- but there is still this error. Thoughts?

JessicaS11 commented 1 year ago

@weiji14 I think it's pretty close to being ready to merge!