Closed JessicaS11 closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
:point_left: Launch a binder notebook on this branch for commit 91e421a5ace3ed951a1baef080496072cc0874d8
I will automatically update this comment whenever this PR is modified
:point_left: Launch a binder notebook on this branch for commit 5b5482b1beeeae9739a908855bc22a5661bc7aaa
:point_left: Launch a binder notebook on this branch for commit d9aacc6bf2a7174aeba24881e9a820d0702edda0
:point_left: Launch a binder notebook on this branch for commit 76ca9eda29e9af112604e349c055140e680d9576
:point_left: Launch a binder notebook on this branch for commit 9a6218762a4dccd19e815b38d08adbaf975151a8
:point_left: Launch a binder notebook on this branch for commit b453b775c18443d351d2907a26779e0ffccdf9a4
:point_left: Launch a binder notebook on this branch for commit 75865261d912f6f0764796a3e74f652245f1ad2b
:point_left: Launch a binder notebook on this branch for commit 71a39a88fc571214c4572b925cdebd99f02e8e76
:point_left: Launch a binder notebook on this branch for commit a6970a050d01951fc898d0144d0e00a365114207
:point_left: Launch a binder notebook on this branch for commit 145106e1635a69afb5cf64af30d2261fe0239cc4
:point_left: Launch a binder notebook on this branch for commit bf8f0202c7f9098c3c1541f14adfc482d34dfbda
:point_left: Launch a binder notebook on this branch for commit 48721c6210df6eb2b173e61358d8b1cfaa1e3ab1
:point_left: Launch a binder notebook on this branch for commit e7e6297671a86ab6d5a696bc2792eb77219ffda8
Patch coverage: 42.42
% and project coverage change: +1.54
:tada:
Comparison is base (
4f64d48
) 57.68% compared to head (e7e6297
) 59.22%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Noting that all tests and the doc build pass currently, but I am about to pin the version of earthaccess to the upcoming release (which thus doesn't yet exist on conda-forge), so they will begin failing because the environment won't be create-able.
One thing I'm probably missing is how Icepyx will work with ATL data in S3 buckets, especially subsetting.
You're missing it because it doesn't exist yet! This is one of the things I will tackle next. I'd like to think some more about how icepyx can further leverage earthaccess and/or Harmony in combination with the Variables module to (as you suggest) think about moving away from EGI. Some of these things will hopefully be a lot easier now that the ICESat-2 data is publicly available on s3, especially once all the cloud metadata is included in CMR (I noticed last week that for ATL15 the s3 urls were not yet available from the initial CMR query). I'm excited for the possibilities!
The long awaited earthaccess (formerly earthdata) python library provides an easy interface for (among other things) authenticating with the NASA EarthData system. This PR remove internal handling of authentication through adoption of earthaccess. The user should see no changes, but this move greatly simplifies things behind the scenes and provides enhanced authentication capabilities for cloud data access.
This work is being done in collaboration with the earthaccess development team, and adoption by icepyx is helping find bugs and drive improvements there (e.g. https://github.com/nsidc/earthaccess/pull/214).