search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
207 stars 106 forks source link

joss publication final #420

Closed JessicaS11 closed 1 year ago

JessicaS11 commented 1 year ago

The JOSS publication is based on v0.6.4, not 0.7.0, so the final publication release needs to be based on the earlier release. The current joss branch + PR (#361) have been had 0.7.0 merged in already. To address this, I created the pubs/joss branch 0.6.4 and applied commits (from dev/main) that were part of the review on top of 0.6.4. This PR takes the commits from the joss publication branch, sans merge commits that update the base to 0.7.0, and squash merges them onto the pubs/joss branch for a publication-specific release. Concurrently, #361 will be squash merged onto development and is effectively an equivalent commit/PR to this one, but onto the most recent base.

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on this branch for commit 000ab2dc3c06b2abe9cbe451a449d9ab52d64851

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 037866412373da0e0a0b1af1ff38b237393bae30

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (pubs/joss@d321131). Click here to learn what that means. Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## pubs/joss #420 +/- ## ============================================ Coverage ? 57.75% ============================================ Files ? 31 Lines ? 2251 Branches ? 433 ============================================ Hits ? 1300 Misses ? 869 Partials ? 82 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icesat2py)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.