fix spot number calculation

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data

https://icepyx.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

203 stars 101 forks source link

fix spot number calculation #458

Closed JessicaS11 closed 9 months ago

JessicaS11 commented 9 months ago

Recent addressing of a dev note brought to light the fact that internal spot number calculations were incorrect. Further investigation showed that this was previously addressed in SlideRule (the function upon which the original icepyx implementation was based) and is now clearly displayed in a table in the ATL03 ATBD (p128), but the changes did not make it upstream into icepyx at the time the error was discovered. This PR updates the spot number calculation and adds a warning for users.

github-actions[bot] commented 9 months ago

:point_left: Launch a binder notebook on this branch for commit 332a923812afb581993460b569eab04f4ebf962e

I will automatically update this comment whenever this PR is modified

:point_left: Launch a binder notebook on this branch for commit a7e28592996d7488557b080416c870cba0244d07

:point_left: Launch a binder notebook on this branch for commit d20b7285f5d06250d5874dfe6e7b4c18feb54b71