search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
203 stars 101 forks source link

add minor/patch release docs #472

Closed JessicaS11 closed 8 months ago

JessicaS11 commented 8 months ago

release documents for v0.8.1 patch release once #470 is merged.

github-actions[bot] commented 8 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 380917cca5928a9eb22d285f03e08f48e8b7c381

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 31f4a209bfbf30273a8d2ea51e258b40eff257c4

Binder :point_left: Launch a binder notebook on this branch for commit 2df2308d0f29d2cc60327a1912202c5c6aafc599

JessicaS11 commented 8 months ago

Not sure why the readthedocs builds are hanging. I just triggered one manually for this branch; #470 (just merged) built successfully and never had the status update properly in the PR yesterday/today...

rwegener2 commented 8 months ago

Not sure why the readthedocs builds are hanging.

That is odd. I found an instance in the readthedocs GH issue history back in 2016 where the servers froze and someone had to go physically inspect to find the problem. I'm not sure if that could be happening here, too.

I have been able to keep working with a local install for the day. Maybe we leave it for a while and if it still isn't working in the morning submit an issue to readthedocs? Or we could just submit an issue now. 🤷🏻‍♀️

JessicaS11 commented 8 months ago

Maybe we leave it for a while and if it still isn't working in the morning submit an issue to readthedocs?

Ordinarily I'd be fine with that plan, but if we want the conda build to be picked up I'd prefer we have the release done tonight since it can take a few hours to get picked up by their bot. I'd have concerns that even if you're showing a pip install someone will try to conda install and then you'll have version issues during the tutorial.

JessicaS11 commented 8 months ago

GitHub is getting a 400 from the readthedocs webhook with message {"detail":"Parameter \"ref\" is required"}. ref seems to be in some of the payloads submitted and not others (depending on the trigger type), but was not previously a problem (across trigger types). So right now pull_request.push triggers seem to be accepted by RTD, but other actions (e.g. pull_request.synchronize) are rejected.

weiji14 commented 8 months ago

Seems like an issue with the GitHub webhook integration - https://github.com/readthedocs/readthedocs.org/issues/10902? Looks like a fix is on the way.

rwegener2 commented 8 months ago

Good find @weiji14! It appears the issue was just resolved. I just re-pushed to trigger a build and the docs seem to have built properly. 🎉