icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
201 stars 100 forks source link

Convert deprecation warnings to errors #482

Closed JessicaS11 closed 6 months ago

JessicaS11 commented 6 months ago

icepyx has a series of deprecations that are still warnings. Some are new deprecations during the modifications for cloud reading, and some are stale but were never turned into errors prior to planned removal. This PR aims to turn all current deprecations into errors for the v1 release, with planned removal of the errors in a future minor release.

github-actions[bot] commented 6 months ago

Binder :point_left: Launch a binder notebook on this branch for commit d04ea3db70da9e73ed8c965e746112c5f22e664e

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 585a8152585232d564aa5a0f8f7bd0bbecdc3a8d

Binder :point_left: Launch a binder notebook on this branch for commit f4503980be4465bfaa90084dbba3f89fa736f823

Binder :point_left: Launch a binder notebook on this branch for commit 5bfd3b956216602bf95afaf21c750463dc1cc86c

Binder :point_left: Launch a binder notebook on this branch for commit 1d5d4655627025a421b234997bdbb9bb6960f72a

Binder :point_left: Launch a binder notebook on this branch for commit 1fada737d331212793673e808ee6d06706d8f265

Binder :point_left: Launch a binder notebook on this branch for commit 6305372068e82f06b95aa4b4fcd3b11784f314e8

Binder :point_left: Launch a binder notebook on this branch for commit 192f107635a5c625c36cf73a8d98279bcffefadb

Binder :point_left: Launch a binder notebook on this branch for commit 06284c0cbd2a75fed2eb600ac0b6b061d8dbe2ca

Binder :point_left: Launch a binder notebook on this branch for commit 05d241a771be523a2b60cfd751ecec15f023ef05

Binder :point_left: Launch a binder notebook on this branch for commit ed3abf376af38635893b8d027425c2cebfc32e2b

Binder :point_left: Launch a binder notebook on this branch for commit 706ffe6499c6c640d3e71068a84fcab9f4ebd78a

Binder :point_left: Launch a binder notebook on this branch for commit 94ab0ceafd81310609c4d3c358fb2f7a8db0e311

Binder :point_left: Launch a binder notebook on this branch for commit c3eb89949439aea8be5dbecefd29cd67f6d681b1

Binder :point_left: Launch a binder notebook on this branch for commit 49357bec0d3a99b4ec45d1f435c8322089b477dd

JessicaS11 commented 6 months ago

@rwegener2 This is basically ready for review, but I figured we'd want to merge #468 first since that's got some code changes in the same areas and there could be merge conflicts.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

JessicaS11 commented 6 months ago

@rwegener2 This is all set for review!

JessicaS11 commented 6 months ago

I'm loving all that code in the Read init that can be eliminated.

Me too! Thanks for the edits.