icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
201 stars 100 forks source link

pkg_resources deprecation: stop calling setup.py directly #500

Closed JessicaS11 closed 4 months ago

JessicaS11 commented 5 months ago

pkg_resources was deprecated as an API several years ago, resulting in numerous warnings. Clear guidance on what, exactly, needs to change is difficult to find if you're not intimately familiar with the build process (even considering the deprecation warning-cited blog post. This is an effort to update actions and package builds to deprecate directly calling setup.py.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on this branch for commit dc9a5f6394511f1fbddbe694dd0f73cd21886635

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit f9cae3750c51d209f6490e8fea892a0160f96f3e

Binder :point_left: Launch a binder notebook on this branch for commit 7ac755113213b0bccb0b96623176d92df547ab55

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b5e9291) 66.19% compared to head (f9cae37) 66.06%.

:exclamation: Current head f9cae37 differs from pull request most recent head 7ac7551. Consider uploading reports for the commit 7ac7551 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #500 +/- ## =============================================== - Coverage 66.19% 66.06% -0.14% =============================================== Files 36 36 Lines 3065 3112 +47 Branches 541 552 +11 =============================================== + Hits 2029 2056 +27 - Misses 945 963 +18 - Partials 91 93 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JessicaS11 commented 5 months ago

@lsetiawan If you have a moment, could you review this PR? I finally dealt with the deprecated pkg_resources warning, and you'd helped set all the packaging up originally and I'm still not confident on packaging stuff.