search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
201 stars 100 forks source link

clean up the read module after adding cloud-read capabilities #502

Closed JessicaS11 closed 5 months ago

JessicaS11 commented 5 months ago

In getting to release of v1.0.0 and getting the functionality of cloud reading in (e.g. #438, #468), we ended up with a few deprecated functions in the read module. This PR removes those and moves some of the input parsing/checking for read into a standalone function that's now tested.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 2ba4cd3c3b2b55cdb0e959b8f6114b7053b939d6

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 420acb3c850f3ea1011af56683d3400e1337f3cd

Binder :point_left: Launch a binder notebook on this branch for commit 487f5a500256ad1e4ae255c34ea1396025527f18

Binder :point_left: Launch a binder notebook on this branch for commit 737005a3b6359d43e29ed039a89a65439b311611

Binder :point_left: Launch a binder notebook on this branch for commit 86a4ad70db514c82275a29142492041ceac604e1

Binder :point_left: Launch a binder notebook on this branch for commit 734a55e79cbf3499d4e0e8769eb0bd133ea8f30f

Binder :point_left: Launch a binder notebook on this branch for commit db4ccdb589d02bcd62214a8d96a23496536a0de9

Binder :point_left: Launch a binder notebook on this branch for commit 8fa662d4181758e10fff9d5bf45d45232940624c

Binder :point_left: Launch a binder notebook on this branch for commit a9a46c5022ffe92d711b0a9ab9ee3e49e0c3fcdf

Binder :point_left: Launch a binder notebook on this branch for commit 8cb9cd9cab90641c10270ff6a04a7326aef352b1

Binder :point_left: Launch a binder notebook on this branch for commit c7cc03ed627fe22a37d51abeb8878cf51ccd634a

Binder :point_left: Launch a binder notebook on this branch for commit 839d4335f7ea61961baa983b27767334d368d4d2

Binder :point_left: Launch a binder notebook on this branch for commit f8b7f0b592e0e33ece2e40cb2d699a4fabce826b

codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (826e936) 66.05% compared to head (db4ccdb) 66.10%.

:exclamation: Current head db4ccdb differs from pull request most recent head f8b7f0b. Consider uploading reports for the commit f8b7f0b to get more accurate results

Files Patch % Lines
icepyx/core/read.py 93.75% 1 Missing :warning:
icepyx/tests/test_read.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #502 +/- ## =============================================== + Coverage 66.05% 66.10% +0.04% =============================================== Files 36 36 Lines 3111 3062 -49 Branches 552 540 -12 =============================================== - Hits 2055 2024 -31 + Misses 963 947 -16 + Partials 93 91 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JessicaS11 commented 5 months ago

@rwegener2 What are the odds you'd have a few moments in the next couple of weeks to review this PR? The diff is slightly confusing based on how GH is formatting it, but the commit messages are a pretty clear list of what's happening for navigation. I may add some more linting fixes before it's merged, but they should only be making long lines shorter so won't change the content.