search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
210 stars 107 forks source link

fix s3url grabbing for .nc files #507

Closed JessicaS11 closed 7 months ago

JessicaS11 commented 7 months ago

Products provided as .nc files (instead of .h5) were not properly collecting s3 urls due to a file type filter used to separate out browse images.

github-actions[bot] commented 7 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 623e5cf0722da9353e5f37fe74860161c8b69bf4

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit d9cee0c67dd071d92f3429fbd8ab28a4411f8c2c

Binder :point_left: Launch a binder notebook on this branch for commit 3d14597d958342df8342a68ec530bb8a4f0da3b0

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3830cf4) 66.06% compared to head (3d14597) 66.05%. Report is 2 commits behind head on development.

Files Patch % Lines
icepyx/core/granules.py 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #507 +/- ## =============================================== - Coverage 66.06% 66.05% -0.02% =============================================== Files 36 36 Lines 3112 3111 -1 Branches 552 552 =============================================== - Hits 2056 2055 -1 Misses 963 963 Partials 93 93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.