Open andypbarrett opened 5 months ago
:point_left: Launch a binder notebook on this branch for commit 1342525464cb5ef785c8cd49b8c166b29a4bc9fc
I will automatically update this comment whenever this PR is modified
:point_left: Launch a binder notebook on this branch for commit acb5a520ae8932bef76f0de1b2661852492a4ade
:point_left: Launch a binder notebook on this branch for commit 4dd740b70a2b764c4932212bac0a0a28086bfe60
:point_left: Launch a binder notebook on this branch for commit 7603309c32dff5d6916bff4cf1daa0c538af02bd
:point_left: Launch a binder notebook on this branch for commit 4054e1f85d64b4a2798185ca6c9539e580f2c180
:point_left: Launch a binder notebook on this branch for commit 4824bd41470456b967606a47d01835ec118a879e
:point_left: Launch a binder notebook on this branch for commit 1d868bd8a5f9f4a8408bb4b155719075c593daaa
:point_left: Launch a binder notebook on this branch for commit e294e31fa2f7e39ccdb2d75e5efef1d73d87bb50
Thanks for the great PR, @andypbarrett! My comments are mostly typos, and hopefully a fix to get the tests via Travis to pass.
Thanks @JessicaS11 and @rwegener2 . I plan on fixing these on Thursday 15 Feb.
Attention: Patch coverage is 10.00000%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 66.02%. Comparing base (
de13727
) to head (e294e31
). Report is 1 commits behind head on development.
Files | Patch % | Lines |
---|---|---|
icepyx/core/variables.py | 10.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This pull request adds the capability to the
Variables.append
method to create wanted variables using a list of explicit paths.path_list
keyword argument was added toappend
.parse_var_list
andset
are used to generate uniquevar_list
,beam_list
,keyword_list
variables. These are then used as they had been in the original version of append.append
was updated to describe the new keyword and give a usage example.var_list
,beam_list
, orkeyword_list
are set. AValueError
is raised if this check fails.path_list
and is modified to useif
instead ofassert
. This allows a more informative Exception to be raised than anAssertionError