icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
201 stars 100 forks source link

Add capability to created wanted variables list with an explicit list of paths #508

Open andypbarrett opened 5 months ago

andypbarrett commented 5 months ago

This pull request adds the capability to the Variables.append method to create wanted variables using a list of explicit paths.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 1342525464cb5ef785c8cd49b8c166b29a4bc9fc

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit acb5a520ae8932bef76f0de1b2661852492a4ade

Binder :point_left: Launch a binder notebook on this branch for commit 4dd740b70a2b764c4932212bac0a0a28086bfe60

Binder :point_left: Launch a binder notebook on this branch for commit 7603309c32dff5d6916bff4cf1daa0c538af02bd

Binder :point_left: Launch a binder notebook on this branch for commit 4054e1f85d64b4a2798185ca6c9539e580f2c180

Binder :point_left: Launch a binder notebook on this branch for commit 4824bd41470456b967606a47d01835ec118a879e

Binder :point_left: Launch a binder notebook on this branch for commit 1d868bd8a5f9f4a8408bb4b155719075c593daaa

Binder :point_left: Launch a binder notebook on this branch for commit e294e31fa2f7e39ccdb2d75e5efef1d73d87bb50

JessicaS11 commented 4 months ago

Thanks for the great PR, @andypbarrett! My comments are mostly typos, and hopefully a fix to get the tests via Travis to pass.

andypbarrett commented 4 months ago

Thanks @JessicaS11 and @rwegener2 . I plan on fixing these on Thursday 15 Feb.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 66.02%. Comparing base (de13727) to head (e294e31). Report is 1 commits behind head on development.

Files Patch % Lines
icepyx/core/variables.py 10.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #508 +/- ## =============================================== - Coverage 66.19% 66.02% -0.18% =============================================== Files 36 36 Lines 3065 3073 +8 Branches 541 544 +3 =============================================== Hits 2029 2029 - Misses 945 953 +8 Partials 91 91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB