search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
216 stars 107 forks source link

Consolidate CI from Travis -> GitHub Actions #547

Closed mfisher87 closed 2 months ago

mfisher87 commented 2 months ago

I'm not very familiar with Travis, but I'm pretty used to Actions and have tools (e.g. https://github.com/nektos/act) and knowledge I can't apply to Travis. I think it'd be better for contributors to only have to know one or the other. Thoughts?

JessicaS11 commented 2 months ago

I'm game to transition from Travis to GitHub actions. @mfisher87, I think you partially did this in setting up the v2 branch? Are you game to implement this change, with the manual trigger option we talked about for enabling tests needing auth to run (with approval) for PRs from forks?

I will add the task of setting up the necessary secrets for early next week.

mfisher87 commented 2 months ago

I'm on it :) But I think I need a refresher on the manual trigger thing. Where'd we talk about that? :thinking: :eyes: I vaguely remember ... we would set it up so a comment by a maintainer with specific text could trigger the auth-tests?

The v2 branch currently includes running the tests that don't require authentication in GitHub Actions, so I can open a PR with that workflow, and also add an "integration test" workflow that does require the creds.