icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
219 stars 107 forks source link

docs: add mfisher87 as a contributor for bug, code, and 4 more #585

Closed mfisher87 closed 3 months ago

mfisher87 commented 3 months ago

Generated by npx all-contributors-cli add mfisher87 bug,code,doc,maintenance,test,infra

Supercedes #584 which really annoyed me with conflicts I didn't want to deal with :)

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on this branch for commit ed94a3fef4e6f6cf7eeab0a30018d257e00e73cf

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 7d80cbf590c1d627da320c37540bfc6a7ff457e1

Binder :point_left: Launch a binder notebook on this branch for commit 5696a179bc0dc03d83d3cff37e51b45683dc6df2

Binder :point_left: Launch a binder notebook on this branch for commit 1a98eb67eafc085470ea1dbec0693123d5c034ec

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.37%. Comparing base (a762ad8) to head (1a98eb6). Report is 29 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #585 +/- ## ============================================ Coverage 65.37% 65.37% ============================================ Files 36 36 Lines 3038 3038 Branches 531 531 ============================================ Hits 1986 1986 Misses 970 970 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

mfisher87 commented 3 months ago

Since I was lazy with resolving merge conflicts, now someone else needs to approve :grimacing: Maybe I should have just done it :laughing:

JessicaS11 commented 3 months ago

Supercedes https://github.com/icesat2py/icepyx/pull/584 which really annoyed me with conflicts I didn't want to deal with :)

I made the mistake of assuming that since the all contributors bot now allowed you to add multiple people at once that it would only open one PR (and thus avoid the conflict issue). I'll stick to my usual MO of only adding one person at a time and not adding anyone new until the first PR is merged.

As a side note, it also mucks up the formatting of the README and requires a re-tab to fix the indentation so it renders correctly. I fixed it here so it addresses this wrong indentation introduced in #583 and #586.

mfisher87 commented 3 months ago

I made the mistake of assuming that since the all contributors bot now allowed you to add multiple people at once that it would only open one PR (and thus avoid the conflict issue)

That's what I would have assumed too!