search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
219 stars 107 forks source link

Extract constant URLs to own module #591

Closed mfisher87 closed 2 months ago

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 2dc7e7856d9a7dd12956d4baa11754a0fda594f6

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 06564c11b8083a7c782f215c1867373f023909e5

Binder :point_left: Launch a binder notebook on this branch for commit cbaff78ec90c84df92208865711cc0ae2d8345ba

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.56%. Comparing base (bd09d73) to head (cbaff78). Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/granules.py 25.00% 3 Missing :warning:
icepyx/core/is2ref.py 66.66% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (bd09d73) and HEAD (cbaff78). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (bd09d73) | HEAD (cbaff78) | |------|------|------| ||3|2|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #591 +/- ## =============================================== - Coverage 71.02% 65.56% -5.47% =============================================== Files 36 37 +1 Lines 3037 3043 +6 Branches 594 594 =============================================== - Hits 2157 1995 -162 - Misses 769 963 +194 + Partials 111 85 -26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mfisher87 commented 2 months ago

Hey @JessicaS11 now that we've merged #547, can you give this another review to trigger integration tests?

mfisher87 commented 2 months ago

Looks like something isn't right :) Looking in to it!

JessicaS11 commented 2 months ago

Looks like something isn't right :) Looking in to it!

I'm noticing that the checks ran (successfully, and interestingly included the integration test) after the precommit auto fixes (https://github.com/icesat2py/icepyx/pull/591/commits/06564c11b8083a7c782f215c1867373f023909e5). My approval triggered the UML auto-update (but not the integration test?), but that commit only triggered readthedocs and precommit checks. I'm guessing the status is missing because for some reason the tests weren't triggered for the head commit, but I don't quite understand why.

mfisher87 commented 2 months ago

I especially don't understand why the unit tests weren't triggered!

JessicaS11 commented 2 months ago

Maybe open PRs are just going to be a bit grumpy at us until we're into ones opened after the actions were implemented?

mfisher87 commented 2 months ago

Weird. Maybe you're right and all will be fine from here!

I opened #595 in case this continues to give us trouble. I want to avoid spending too much of our limited time getting things perfect :)