icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
218 stars 107 forks source link

Type annotate the temporal module #604

Closed mfisher87 closed 1 month ago

mfisher87 commented 2 months ago

[!IMPORTANT]

To be merged only after merging #598 and then rebasing

Annotating this module was pretty quick! No typeguards or ignores needed.

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 7f922611f86814d7a77246f83929a63d7162b4e6

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit e805f01ae1d8d8dbd549e22d7c48f85f51cdbaf0

Binder :point_left: Launch a binder notebook on this branch for commit 7b57037c39981e577e6968028c6f25e2740c325d

Binder :point_left: Launch a binder notebook on this branch for commit 224ca75d6eb2d0f500d49d8ad63ce3dc058940e0

Binder :point_left: Launch a binder notebook on this branch for commit df965c25f16528a56143bf662b561d2d4140bea5

Binder :point_left: Launch a binder notebook on this branch for commit 7751e26d39c2141ff41884d58b8dc992e7cfa402

Binder :point_left: Launch a binder notebook on this branch for commit d037e1140b9274225adff6a30b664b2c80b0cb52

Binder :point_left: Launch a binder notebook on this branch for commit 094d3f0e81b57eb6078538998608be43b19e0a6e

Binder :point_left: Launch a binder notebook on this branch for commit 97a5544f7e059c2bd1869c7d587c11c4281be3f2

Binder :point_left: Launch a binder notebook on this branch for commit b0eb2b97a9269dd1f3d2e908312b1c699c3f9028

Binder :point_left: Launch a binder notebook on this branch for commit af907f37a85f1ad93eb92a3e3e1c535df8b87265

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.79%. Comparing base (b7e07bf) to head (af907f3). Report is 1 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #604 +/- ## =============================================== - Coverage 71.78% 66.79% -4.99% =============================================== Files 38 36 -2 Lines 3133 3078 -55 Branches 599 593 -6 =============================================== - Hits 2249 2056 -193 - Misses 773 933 +160 + Partials 111 89 -22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mfisher87 commented 1 month ago

Thanks for the thorough review :bow:

I don't understand why the unit tests aren't running here. Re-opening PR to trigger.

JessicaS11 commented 1 month ago

I don't understand why the unit tests aren't running here. Re-opening PR to trigger.

618