search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
219 stars 107 forks source link

Mark tests which depend on ECS as expected fail; separate integration and unit tests #609

Closed mfisher87 closed 2 months ago

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on this branch for commit d9179992b80f1b4b85fd39649d1a431b661e84f5

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 084ab7d9e508317c45a63f65b93342c7eb6fdbde

Binder :point_left: Launch a binder notebook on this branch for commit 3430c898f71f15c644eab69ba741891ef53b1892

Binder :point_left: Launch a binder notebook on this branch for commit b773376d292491cb1e147402e8a2d394009e5cf2

Binder :point_left: Launch a binder notebook on this branch for commit 25346ea273c8f785606d659c527e3df35e83525b

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.68%. Comparing base (0f2cfeb) to head (25346ea).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #609 +/- ## =============================================== + Coverage 65.47% 66.68% +1.21% =============================================== Files 38 36 -2 Lines 3134 3077 -57 Branches 601 594 -7 =============================================== Hits 2052 2052 + Misses 991 935 -56 + Partials 91 90 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mfisher87 commented 2 months ago

Yes, excellent catch, thank you! I thought I had the conftest.py in the integration directory, but clearly not! Both types of tests turn out to require fixtures from conftest.py. I'd recommend having one conftest.py for unit tests and another for integration tests, but didn't want to increase the scope of the PR :) The __init__.py seems to not be needed.

b773376

mfisher87 commented 2 months ago

Integration tests run:

https://github.com/icesat2py/icepyx/actions/runs/11040360996/job/30668167255

The tests marked xfail have status XPASS (unexpected pass), which is considered OK by default.

JessicaS11 commented 2 months ago

Something funny happened with the timing and I can't get the unit tests to run and report a status based on https://github.com/icesat2py/icepyx/pull/609/commits/9a9d67a5fb4345b7dfcef1b298cb9dfe2c11eeb0. But they were passing before the UML updates so I'm going to use admin to merge. See #618.