search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
218 stars 107 forks source link

A collection of "low-hanging fruit" refactors #612

Open mfisher87 opened 1 month ago

mfisher87 commented 1 month ago

[!IMPORTANT] To be merged only after merging #605 and rebasing

I'm happy to split this in to multiple PRs, but there's a lot of disparate changes here and I didn't want to flood the queue before showing you the whole pile. Let me know!

github-actions[bot] commented 1 month ago

Binder :point_left: Launch a binder notebook on this branch for commit 91bd9a8bc45f5e5c8548fb6f4331dd46628d3658

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit b75d000346e2dba139fea1c1e6ed43a1b763d60b

Binder :point_left: Launch a binder notebook on this branch for commit 2e7ac199569de4a742a362c5f522909cc375670a

Binder :point_left: Launch a binder notebook on this branch for commit e6151d1ba5cfadc46ab66519cdd2adbe7da7f45f

Binder :point_left: Launch a binder notebook on this branch for commit 4dc2872015eff3ad9cec6036a1ca8f7ad9075473

Binder :point_left: Launch a binder notebook on this branch for commit a180892a3f253f52009c7d4c6915195bd521398e

Binder :point_left: Launch a binder notebook on this branch for commit 88459e59994dedba256530f1935cd04f8c600c03

Binder :point_left: Launch a binder notebook on this branch for commit 77112b7943de3bfab06e06db361752f73aaed5d0

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 79.10448% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (7675584) to head (77112b7).

Files with missing lines Patch % Lines
icepyx/core/is2ref.py 54.54% 9 Missing and 1 partial :warning:
icepyx/core/query.py 87.09% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## typecheck-spatial #612 +/- ## ===================================================== + Coverage 67.76% 67.83% +0.06% ===================================================== Files 36 37 +1 Lines 3149 3146 -3 Branches 430 426 -4 ===================================================== Hits 2134 2134 + Misses 931 928 -3 Partials 84 84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

trey-stafford commented 2 weeks ago

Looks like this PR is ready-to-go pending #605

JessicaS11 commented 1 day ago

Looks like this PR is ready-to-go pending https://github.com/icesat2py/icepyx/pull/605

Any idea why this shouldn't go directly into development?

trey-stafford commented 7 hours ago

Looks like this PR is ready-to-go pending #605

Any idea why this shouldn't go directly into development?

This work is based on what's in #605 . We might be able to pull out the changes from this PR independently if we decide not to move forward with #605 though.