search

icesat2py / icepyx

Python tools for obtaining and working with ICESat-2 data
https://icepyx.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
219 stars 107 forks source link

Bugfix: Move `loop_root` sentinel value above exhaustive conditionals #616

Closed mfisher87 closed 2 months ago

mfisher87 commented 2 months ago

The development branch doesn't pass integration tests due to this mistake introduced in #593.

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on this branch for commit dda218429e07c9e67f59e727bfb82bd600a722e1

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit e2dbf3253a1d8fe1c644784233baf9134c598b69

Binder :point_left: Launch a binder notebook on this branch for commit 30ddf30cb8d14c8fe5c2f955b8b4491563124fee

Binder :point_left: Launch a binder notebook on this branch for commit 8cbbcbebc2512b95f29f40b3c927ebbbdc183aa4

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (74ca632) to head (8cbbcbe). Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/granules.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #616 +/- ## =============================================== - Coverage 71.48% 66.68% -4.80% =============================================== Files 38 36 -2 Lines 3135 3077 -58 Branches 600 594 -6 =============================================== - Hits 2241 2052 -189 - Misses 783 935 +152 + Partials 111 90 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.