search

icetee / node-ftp

An FTP client module for node.js
MIT License
25 stars 16 forks source link

fixes keepalive bug #17

Closed oldrich-svec closed 4 years ago

oldrich-svec commented 4 years ago
oldrich-svec commented 4 years ago

Maybe it would conflict with

socket.setKeepAlive(options.keepalive > 0);

?

Venlig hilsen

Oldrich Svec Konsulent, ph.d.

+45 72 20 13 62

Teknologisk Institut www.teknologisk.dkhttp://www.teknologisk.dk/

From: Tamás András Horváth notifications@github.com Sent: 18 May 2020 12:35 To: icetee/node-ftp node-ftp@noreply.github.com Cc: Oldrich Svec osv@teknologisk.dk; Author author@noreply.github.com Subject: Re: [icetee/node-ftp] fixes keepalive bug (#17)

If 0 is also a value, shouldn't it be allowed? And exclude with -1. What do you think?

if (self.options.aliveTimeout >= 0) {

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/icetee/node-ftp/pull/17#issuecomment-630096245, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKSWRJX7FHUZOV6N22F3TX3RSEFM5ANCNFSM4ND46Q3A.

icetee commented 4 years ago

I thought it was good that way. Thanks.

On 2020. May 18. at 12:40:09, oldrich-svec (notifications@github.com) wrote:

Maybe it would conflict with

socket.setKeepAlive(options.keepalive > 0);

?

Venlig hilsen

Oldrich Svec Konsulent, ph.d.

+45 72 20 13 62

Teknologisk Institut www.teknologisk.dkhttp://www.teknologisk.dk/

From: Tamás András Horváth notifications@github.com Sent: 18 May 2020 12:35 To: icetee/node-ftp node-ftp@noreply.github.com Cc: Oldrich Svec osv@teknologisk.dk; Author author@noreply.github.com Subject: Re: [icetee/node-ftp] fixes keepalive bug (#17)

If 0 is also a value, shouldn't it be allowed? And exclude with -1. What do you think?

if (self.options.aliveTimeout >= 0) {

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/icetee/node-ftp/pull/17#issuecomment-630096245>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AKSWRJX7FHUZOV6N22F3TX3RSEFM5ANCNFSM4ND46Q3A>.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/icetee/node-ftp/pull/17#issuecomment-630098565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOE63GX3NXBAKZWS6YHDGTRSEGATANCNFSM4ND46Q3A .