search

icetee / node-ftp

An FTP client module for node.js
MIT License
25 stars 16 forks source link

Send commands in latin-1 #22

Open Kreijstal opened 3 years ago

Kreijstal commented 3 years ago

I have a server that seems to accept latin-1 and not utf-8 only, and there is currently no way, to do this, could this be added?

icetee commented 3 years ago

I think the commands is latin-1 (english characters), but if the filenames use utf-8, I don't think we can do anything because the local and the server will be inconsistent.

Could you describe a situation? And do you have information about the type and version of the FTP server?

Kreijstal commented 3 years ago

image This screenshot probably describes the situation, it works in latin-1 but not in UTF-8 Also, I forked this project, and added this line and seems to work on my server now! https://github.com/icetee/node-ftp/compare/master...kreijstal-contributions:master The problem is that it won't work if the server expects utf8 (which is what filezilla does), or a server that supports "OPTS UTF-8 ON", so you probably should make it a setting.