search

icetee / node-ftp

An FTP client module for node.js
MIT License
25 stars 16 forks source link

Add Implicit Connection with Secure Data #5

Open simy307 opened 6 years ago

simy307 commented 6 years ago

Currently a connection can be made with the "Implicit" option. However the data being transferred is not encrypted and an error would be passed down from the server

522 Data connections must be encrypted

This change would allow a connection with both an "Implicit" connection type and "Secure" data.

icetee commented 6 years ago

I watched your code, but is the same as if I set "secure": true. If true, then encrypted data and commucation channel.

Otherwise, I get an error:

events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: 11000:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:openssl\ssl\record\ssl3_record.c:252:

    at Socket.ondata (internal/wrap_js_stream.js:62:22)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:280:12)
    at readableAddChunk (_stream_readable.js:265:11)
    at Socket.Readable.push (_stream_readable.js:220:10)
    at TCP.onread (net.js:638:20)
Emitted 'error' event at:
    at TLSSocket.onerror (D:\DEV\_forks\node-ftp\lib\connection.js:311:10)
    at TLSSocket.emit (events.js:182:13)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at process._tickCallback (internal/process/next_tick.js:174:19)