icetee / remote-ftp

FTP/FTPS/SFTP client for Atom.io
MIT License
555 stars 102 forks source link

Uncaught ReferenceError: reentry is not defined #1078

Open jaycelcunanan opened 6 years ago

jaycelcunanan commented 6 years ago

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.22.1 x64 Electron: 1.6.15 OS: Microsoft Windows 8.1 Single Language Thrown From: Remote-FTP package 2.1.1

Stack Trace

Uncaught ReferenceError: reentry is not defined

At C:\Users\Jaycel Cunanan\.atom\packages\Remote-FTP\node_modules\@icetee\ftp\lib\connection.js:937

ReferenceError: reentry is not defined
    at /packages/Remote-FTP/node_modules/@icetee/ftp/lib/connection.js:937:18
    at /packages/Remote-FTP/node_modules/@icetee/ftp/lib/connection.js:996:7)
    at Object.onceWrapper (events.js:290:19)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at TCP._handle.close [as _onclose] (net.js:501:12)

Commands

     -0:50.1.0 tree-view:remove (span.name.icon.icon-file-text)
     -0:42.3.0 remote-ftp:create-ftp-config (div.tool-panel.tree-view)
  3x -0:24.8.0 core:paste (input.hidden-input)
     -0:16.9.0 core:save (input.hidden-input)
     -0:13.5.0 remote-ftp:connect (ul.list-inline.tab-bar.inset-panel)

Non-Core Packages

Remote-FTP 2.1.1 
egirlasm commented 6 years ago

same issue

hanzinhee commented 6 years ago

same issue

moshebendavid commented 6 years ago

same issue

iampatrick commented 6 years ago

Same. :)

antonfeijoomontenegro commented 6 years ago

Same issue.

kentaro-a commented 6 years ago

I have the same..

Haylin-chama commented 6 years ago

Same issue with a specific IP. Amazon server.

ol1s commented 6 years ago

Same issue with AWS server. Interestingly the exception does not occur when testing with Remote-FTP v1.3.4

jovicon commented 6 years ago

@Haylin-chama did you find any solution? I have same issue. :(

triss90 commented 6 years ago

Same issue, with an AWS server :(

icetee commented 6 years ago

Can you help reproduction? Create an S3?

Haylin-chama commented 6 years ago

@jovicon No, because AWS needs a public key and i don't know how to add it to the .ftpconfig file.

icetee commented 6 years ago

Create authorized_keys file, use SFTP config and set privatekey property ~/.ssh/rsa_id https://github.com/icetee/remote-ftp/issues/1151

james090500 commented 6 years ago

Any Updates on this? Only does it with one of my servers which works fine in filezilla

Ray-Eldath commented 5 years ago

same ((( Any updates ?

supraniti commented 5 years ago

+1

wolfkang commented 5 years ago

Hi, I modified line 907 in the connection.js file.

C:\Users\ [User Home] \.atom\packages\remote-ftp\node_modules\@icetee\ftp\lib\connection.js

Before this._send(pasvCmd, function (err, text) {

After this._send(pasvCmd, function reentry(err, text) {

Good luck :)

AlejandroMataGuillen commented 5 years ago

I'm experimenting this issue from promise-ftp library, when I use the solution from @wolfkang it works well, is there some workaround for that without edit the file manually because I need to ship my project with docker

StockDave commented 4 years ago

Hi, I modified line 907 in the connection.js file.

C:\Users\ [User Home] .atom\packages\remote-ftp\node_modules@icetee\ftp\lib\connection.js

Before this._send(pasvCmd, function (err, text) {

After this._send(pasvCmd, function reentry(err, text) {

Good luck :)

works well on node apps, thanks

robertandrews commented 4 years ago

Suddenly appearing.

Uncaught ReferenceError: reentry is not defined
/Users/Robert/.atom/packages/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:943
Hide Stack Trace
ReferenceError: reentry is not defined
    at /Users/Robert/.atom/packages/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:943:11
    at Socket.<anonymous> (/Users/Robert/.atom/packages/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:1002:7)
    at Object.onceWrapper (events.js:315:30)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at TCP._handle.close [as _onclose] (net.js:554:12)
The error was thrown from the remote-ftp package. This issue has already been reported.

@wolfkang's fix seems to work.

aliasmac commented 4 years ago

@wolfkang fix worked for me as well.

JLRishe commented 3 years ago

It looks like this issue was fixed around version 1.0.6 of @icetee/node-ftp, and this library was updated to use version 1.0.7 about a year ago.

With that in mind, the offending code was in some error handling code that is only run when there is a failure to establish a passive connection. So if you were seeing this error, it may mean that your FTP server is misconfigured (e.g. it is reporting the wrong passive connection IP address).

Fogrunner commented 3 years ago

C:\Users\Morgan.atom\packages\remote-ftp\node_modules\@icetee\ftp\lib\connection.js:947 Hide Stack Trace ReferenceError: reentry is not defined at C:\Users\Morgan.atom\packages\remote-ftp\node_modules\@icetee\ftp\lib\connection.js:947:11 at C:\Users\Morgan.atom\packages\remote-ftp\node_modules\@icetee\ftp\lib\connection.js:972:9

It is still happened to me. After logged, it is hanging on getting list. I am using 2.2.4 version.

It is only happened on specific Amazon server. I have tested to access the ftp server with another application. The application works well without any problem.

Fogrunner commented 3 years ago

If someone has the same problem, use sftp connection way with Amazon key-pair.

Below is the sample configuration:

{ "protocol": "sftp", "host": "[YOUR SERVER ADDRESS HERE]", // example.co.kr "port": 22, "user": "[YOUR ACCOUNT NAME HERE]", // steven "pass": "pass", "promptForPass": false, "remote": "[YOUR HOME DIRECTORY ON THE SERVER]", // /home/steven "local": "", "agent": "", "privatekey": "[YOUR KEY PAIR FILE LOCAL PATH HERE]", // c:\amazon-keypairs\mykey.pem "passphrase": "", "hosthash": "", "ignorehost": true, "connTimeout": 10000, "keepalive": 10000, "keyboardInteractive": false, "keyboardInteractiveForPass": false, "remoteCommand": "", "remoteShell": "", "watch": [], "watchTimeout": 500 }