icetee / remote-ftp

FTP/FTPS/SFTP client for Atom.io
MIT License
556 stars 102 forks source link

.ftpignore doesn't work when I ignore folder #972

Open GNXB opened 7 years ago

GNXB commented 7 years ago

[remote-ftp version: 1.1.3 on Atom 1.20.0 x64 OS X El Capitan] I has a large folder size on the remote machine and I want to prevent downloading it to my working machine. But when I perform Right-Click on remote-ftp panel at the root folder and click "Download" or "Sync Local <- Remote", then it performs downloading all of files and folders also "The Large One" to my machine.

Now I can done is Manually download each sub folder (Right Click -> Download several times)

Here is my .ftpignore file. Does I config it correctly? Thank you.

screen shot 2560-09-19 at 12 28 10 pm
guitarbeerchocolate commented 7 years ago

Same here on Linux. .ftpignore is (ironically) ignored.

ghost commented 6 years ago

I have issues with every folder and .ftpignore itself, they all get uploaded to the server.

PhKi commented 6 years ago

Sad to see this bug ignored for a Month now.. Ignoring a folder shouldn't be that difficult to implement. I dont want to sync the whole node_modules folder everytime.. For everyone with the same problem i can recommend remote-sync, ignoring works for folders and files and watching works for files. Although im still waiting for the feature to set wildcards for watching, but as im aware they're working on it. oh and its a bit faster than remote-ftp

icetee commented 6 years ago

If it is not difficult for you, next time we wait for your pull request.

It works for all downloads. https://github.com/icetee/remote-ftp/commit/344d3af7c153fec78745d1d5ce2a8d769355e611

Upload soon ...

ghost commented 6 years ago

@icetee how is this an enchanement? it's a straight up bug. folders (and files within them) are getting uploaded while they are in the .ftpignore, so the ftpignore doesn't work for folders, it's a bug.

icetee commented 6 years ago

Unfinished development. The original issue was only downloaded.

ghost commented 6 years ago

@icetee but it's also the other way around, whenever I upload index.js (by CMD + S), the node_modules/ folder get's uploaded from local to remote, while in .ftpignore it contains node_modules/

icetee commented 6 years ago

@kevzdev After you've typed it into the .ftpignore file, disconnected?

pixelliquid commented 6 years ago

Issue still persists. Can't ignore folders. My .ftpignore:

.ftpconfig
.ftpignore
id_rsa
.DS_Store
.git
*/node_modules
sample*

The .git folder is still being synced, as well as the node_modules folder. All files in the root with sample in their names are rightly ignored. Perhaps it is a typo on my behalf. The path of the node_module folder is site/themes/theme/node_modules.

ghost commented 6 years ago

@icetee yes, I've disconnected after. Issue still persists. @PeterEmil I have the exact same problem.

emoruzzi commented 6 years ago

I ran into the same issue using version 1.2.3 and 2.1.0. You can work around the issue by restarting atom any time you change the .ftpignore file; since it's set to load on start.

I created a PR to address this issue: https://github.com/icetee/remote-ftp/pull/1076/

FranklinYu commented 6 years ago

Even restart doesn't work for me. I'm on Windows, if it matters.

rustyforeal commented 6 years ago

any updates on this?

wendyliga commented 6 years ago

waiting , how to add a single file on .ftpignore? just type the filename with extension ?

emoruzzi commented 6 years ago

The original issue was for .ftpignore not working on macOS; what version of windows are you having the issue on?

wendyliga commented 6 years ago

Oh thats was the reason , i use mac

emoruzzi commented 6 years ago

@wendyliga The remote-ftp package uses the npm ignore package; which is similar to how a gitignore file would work. https://github.com/icetee/remote-ftp#how-to-use-ftpignore

You can find more information about how to use the ignore file at https://git-scm.com/docs/gitignore

FranklinYu commented 6 years ago

@emoruzzi Is this supposed to be a mac-only issue? I’m experiencing same issue on Windows 10.

Balloota commented 6 years ago

also have the same issue... it messed up stuff that shouldn't be changed on the remote :(

TomS- commented 6 years ago

I'm also having this issue on Mac, even .ftpignore file is being uploaded, however it does show greyed out in the remote file tree.

ghost commented 6 years ago

Same here, Windows 10. It doesn't matter what I write into the .ftpignore file, it's syncing everything, even itself. Files, folders, everything. It just straight up does not work.

eagl3s1ght commented 6 years ago

Could it be user permission problem? Mine worked after running Atom as Administrator.

ghost commented 6 years ago

Not likely, I always run Atom with sudo.

SZOKOZ commented 5 years ago

06/11/2018 Still not fixed. :/

eugenelet commented 5 years ago

Is this issue fixed yet? It's really bad for my SSD to download large files from remote server.

JRudransh commented 5 years ago

How to prevent specific file upload using ftp ignore. It uploading my all scss files also.

JRudransh commented 5 years ago

Still Not Fixed??

DuchSuvaa commented 4 years ago

same here, like the ignore file didnt exist at all

rossmaidment commented 3 years ago

Also experiencing this problem (using Atom v1.53 and remote-ftp v2.2.4) on MacOS. All local files, including .ftpconfig and those specified in .ftpignore are uploaded to remote server. This didn't happen in previous versions. I've reinstalled Atom/remote-ftp and restarted my Mac, but it's still not working. Any suggestions welcome.

moerphie commented 2 years ago

Same issue here for a while. I'm using Atom v1.60.0 and remote-ftp v2.2.4 (macOS).