search

icexin / eggos

A Go unikernel running on x86 bare metal
http://eggos.icexin.com
MIT License
2.21k stars 112 forks source link

warn when attempting to run egg using an unsupported version of go #113

Open alexflint opened 11 months ago

alexflint commented 11 months ago

Thank you for this wonderful package!

I wonder whether you are interested in this pull request that checks that the version of go being executed is 1.16. With the wrong version of go, it looks like this:

$ egg build
2023/07/22 11:32:28 eggos requires go 1.16 but found go version go1.20.5 linux/amd64

Perhaps the test in this PR is too severe. Does eggos support older version of go, such as 1.15?

mewmew commented 11 months ago

Hi @alexflint!

You are right in that Eggos is currently tied to Go 1.16. Support for Go 1.17 and above requires support for the custom asm calling convention introduced in Go 1.17 (see #100).

Regarding the warning message. Would it enough to do this on the go.mod level?

module github.com/icexin/eggos

go 1.16

Cheers, Robin