icflorescu / mantine-datatable

The table component for your Mantine data-rich applications, supporting asynchronous data loading, column sorting, custom cell data rendering, context menus, nesting, Gmail-style batch row selection, dark theme, and more.
https://icflorescu.github.io/mantine-datatable/
MIT License
916 stars 66 forks source link

Rem warnings in console #221

Closed imoby closed 1 year ago

imoby commented 1 year ago

Describe the bug As of 2.0 version, I'm starting to see warnings in the console that mention things like: Unexpected value 1.375rem parsing width attribute.

and this only happens in places that use mantine datatable. It will log this many times in my console. I've upgraded my mantine version to 6.0 too

To Reproduce Steps to reproduce the behavior:

  1. Create a project with mantine 6.0 and add mantine data table
  2. Observe when adding data, in my case about 5+ columns, that there are warnings that show in the console

Expected behavior Warnings should not be displayed

Screenshots image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

icflorescu commented 1 year ago

Judging from your screenshot, I understand this happens on Firefox.

I've noticed similar warnings related to Mantine 6.x and most likely it's something to do with their migration to rem units. Unfortunately there's nothing I can do about it in Mantine DataTable, as the warnings are coming from the underlying components I'm using.

Do you see similar warnings when accessing various pages in mantine.dev?

icflorescu commented 1 year ago

See here and here.

icflorescu commented 1 year ago

I'm going to close this for now, since it's not strictly related to Mantine DataTable but to Mantine.