icflorescu / mantine-datatable

The table component for your Mantine data-rich applications, supporting asynchronous data loading, column sorting, custom cell data rendering, context menus, nesting, Gmail-style batch row selection, dark theme, and more.
https://icflorescu.github.io/mantine-datatable/
MIT License
899 stars 66 forks source link

drag and drop with @hello-pangea/dnd #513

Closed mehdiraized closed 1 month ago

mehdiraized commented 7 months ago

mantine has sample for drag and drop rows in table but we need access to row render for use this package and add this feature https://ui.mantine.dev/category/dnd/

image

icflorescu commented 7 months ago

Other users requested the feature too but no one came up with a valid PR so far, and I'm afraid I don't have the luxury of free time at the moment.

So, I'm 💯 percent open to a PR regarding this!

MohdAhmad1 commented 2 months ago

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

icflorescu commented 1 month ago

I'm really curious to see other people's feedback on the PR addressing this issue. My primary concern in regarding the addition of a new mandatory dependency (Pangea DnD).

mehdiraized commented 1 month ago

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

can you change your code and create a new page in Examples, if you want to use the Pangea DnD, you can install the package and put the sample code on that page.

MohdAhmad1 commented 1 month ago

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

can you change your code and create a new page in Examples, if you want to use the Pangea DnD, you can install the package and put the sample code on that page.

I have already added an example page in /examples/row-dragging/

mehdiraized commented 1 month ago

i fixed this issue on this commit https://github.com/icflorescu/mantine-datatable/pull/621/commits/ee6b61bfb3ac8221b190078ebf4eee808e48312f

mehdiraized commented 1 month ago

@icflorescu can you check that PR ? everything is ok in this PR please check that

icflorescu commented 1 month ago

Thanks for the outstanding work, release is on its way to npm registry!