search

icflorescu / mantine-datatable

The table component for your Mantine data-rich applications, supporting asynchronous data loading, column sorting, custom cell data rendering, context menus, nesting, Gmail-style batch row selection, dark theme, and more.
https://icflorescu.github.io/mantine-datatable/
MIT License
911 stars 66 forks source link

Pagination Shows "..." if fetching is true but there is pagination data provided #614

Closed mgreenw closed 3 weeks ago

mgreenw commented 3 months ago

Describe the bug If there is pagination data provided (totalRecords, recordsPerPage, and page) but fetching is true, I expect the pagination fields to continue rendering normally while the rest of the data in the table shows a loading spinner. The use case is that it should be possible to fetch the pagination data and the actual data separately so there is no unexpected "..." while I'm fetching a new page of data

To Reproduce Steps to reproduce the behavior:

  1. In the async loading example, separate out the data fetching from the "pagination info" fetching (e.g. the total number of results in the set). Fetching the pagination info should not require the page or page size as input, and thus the data doesn't change when you change pages
  2. Use the pagination info to supply totalRecords, recordsPerPage, and page
  3. When the page changes and fetching: true, the pagination turns into ..., even though the three above fields are properly set

Expected behavior I expect to see the pagination fields whenever totalRecords, recordsPerPage, and page are set.

Screenshots

Screenshot 2024-07-01 at 5 40 10 PM

Desktop (please complete the following information):

candogusyilmaz commented 1 month ago

I'm experiencing this issue after i updated all of the npm packages which had mantine-datatable aswell. I believe it doesn't update the totalRecords when changed. It happens when totalRecords is undefined in my scenario.