icfnext / cq-component-maven-plugin

Other
22 stars 35 forks source link

Multifield #50

Closed brennhill closed 7 years ago

brennhill commented 7 years ago

From my team around allowing multifield and composite fields.

michaelhodgdon commented 7 years ago

This appears to be duplicating the functionality of the DialogFieldSet that is already in place. Is that not meeting your use case?

brennhill commented 7 years ago

Our understanding was that the DialogFieldSet created a set of fields, this is more about creating dialogs from nested subclasses and having those get pulled into the final dialog. Was our understanding incorrect? We didn't find docs specifying exactly what DialogFieldSet does/is meant to do.

michaelhodgdon commented 7 years ago

DialogFieldSet creates a set of fields using a nested class. You can also extend other classes to add fields from them (http://code.digitalatolson.com/cq-component-maven-plugin/usage.html#/Inheritance)

brennhill commented 7 years ago

ok, we'll cancel it. Thanks for the explanation.