icfnext / cq-component-maven-plugin

Other
22 stars 34 forks source link

Dependencies inclusion from all available bundles #70

Open drfits opened 7 years ago

drfits commented 7 years ago

Hello, we have a multi-module project. Each module contains a set of components(with dialog) and dependencies to other modules. After compilation we have a set of dialogs not only from current module but also from other modules. To exclude this unwanted dependencies from construction process we can use excludeDependencies but we should maintain this list of exclusions and validate generated dialogs every time for every module after any dependency changes. To facilitate this process and prevent from generation of unwanted dialogs we can intend includeDependencies option where we could specify dependencies from which we desire to compile dialogs and skip other related dependencies. Pull request with implementation was created here - pull 69. Description of implementation:

  1. By default if either includeDependencies nor excludeDependencies was omitted construction process consider all compile/provided/system scope dependencies from maven module.
  2. If includeDependencies was specified the construction process will consider components only from specified compile/provided/system scope dependencies.
  3. If excludeDependencies was specified the construction process will consider components within specified compile/provided/system scope dependencies except dependencies specified in *excludeDependencies**
  4. If both includeDependencies and excludeDependencies were specified includeDependencies takes priority and excludeDependencies will not be considered by construction process

Thanks for considering this request @michaelhodgdon @pmichelotti