search

icfpcontest2020 / dockerfiles

MIT License
14 stars 36 forks source link

Monorepo for docker files and starter kits #25

Open Vlad-Shcherbina opened 4 years ago

Vlad-Shcherbina commented 4 years ago

As you can see, pull requests often come in pairs: one to dockerfiles and one to whatever-starter-kit. It should be one atomic change. Furthermore, it's inconvenient for contributors to propose new platforms without you creating a new empty starter kit repo first.

Consider merging all this stuff into a monorepo.

It will make getting started a bit harder (one can't just clone favorite-language-starter-kit, has to copy a sub-directory), but I think it's worth it.

beevee commented 4 years ago

It makes sense, but our current process more closely resembles actual contest situation: separate repository that contains team solution, separate repository that contains Dockerfiles. We have an internal CI that continuosly checks all starterkits against current Dockerfiles, so I can make sure everything works.

Your suggestion is valid though. I'll give it a thought.