icgc-argo / argo-dictionary

Development of the ARGO Data Dictionary
https://docs.icgc-argo.org/dictionary
GNU Affero General Public License v3.0
2 stars 1 forks source link

393 immunotherapy drug dose #395

Closed hknahal closed 1 year ago

hknahal commented 1 year ago

Related to https://github.com/icgc-argo/argo-dictionary/issues/393

New fields for prescribed and actual drug dose (similar to chemotherapy and hormone therapy) were created. These fields did not previously exist in the immunotherapy schema:

hknahal commented 1 year ago

Testing for this change is similar to https://github.com/icgc-argo/argo-dictionary/pull/394, where the same fields (prescribed_cumulative_drug_dose and actual_cumulative_drug_dose) were added in the chemotherapy and hormone_therapy schema files as well.

Tested in QA using dictionary version 123.*:

Either the prescribed_cumulative_drug_dose or the actual_cumulative_drug_dose needs to be submitted. If either one is submitted, the validation should pass, but if both are missing, then the validation should fail with an error message.

Test case 1: prescribed_cumulative_drug_dose is submitted and actual_cumulative_drug_dose is left empty.

Test files: donor_testcase1.txt primary_diagnosis_testcase1.txt treatment_testcase1.txt chemotherapy_testcase1.txt immunotherapy_testcase1.txt

Expected validation: This validation should pass. immunotherapy_testcase1

Test case 2: Both prescribed_cumulative_drug_dose and actual_cumulative_drug_dose are missing.

Test files: donor_test_case2.txt primary_diagnosis_test_case2.txt treatment_test_case2.txt chemotherapy_test_case2.txt immunotherapy_test_case2.txt

Expected validation: This validation should fail reporting an error message indicating both fields are missing and at least one should be submitted. immuno_test_case2

Buwujiu commented 1 year ago

Tested in QA TEST-CA, working as expected!