search

icgc-argo / argo-dictionary

Development of the ARGO Data Dictionary
https://docs.icgc-argo.org/dictionary
GNU Affero General Public License v3.0
2 stars 1 forks source link

Update validation scripts to take into account exception values (Unknown and Not applicable) #407

Closed hknahal closed 1 year ago

hknahal commented 1 year ago

When an exception value is applied to a field that is conditional, the validation needs to take the new exception value into account.

Example: The field lymph_nodes_examined_method is dependent on lymph_nodes_examined_status field. The current validation script does not take the value Unknown into account and needs to be updated to include it. The field lymph_nodes_examined_method should not be submitted if lymph_nodes_examined_status is Unknown.

dict_change

hknahal commented 1 year ago

If tumour_grading_system has an exception value of Not applicable but tumour_grade is not Not applicable also, the error message is not clear. It should say:

'G2' is not a permissible value. When 'tumour_grading_system' is set to 'Not applicable', 'tumour_grade' must be one of the following: Not applicable

tumour_grade_error_message

hknahal commented 1 year ago

Closing ticket. Released in Dictionary version 1.18